I have tested this item successfully on 8686573

Almost but now the folder tree is not scrollable so only shows a partial tree

Sorry that should have been a failed test

Almost but now the folder tree is not scrollable so only shows a partial tree

yes, i think it needs a scroll:

Almost but now the folder tree is not scrollable so only shows a partial tree

Yes i see, but it's not related to display issue, but to the fail of the layout to get the right $selector (i was just explaining it in your issuer report ;-)

All I know is that there was a scroll before

BTW before the scroll was on the entire page - i discovered this issue when
i was trying to write a PR that would make the left hand column scroll but
keep the right hand column fixed

On 13 April 2016 at 14:53, Cyril Rezé notifications@github.com wrote:

Almost but now the folder tree is not scrollable so only shows a partial
tree

Yes i see, but it's not related to display issue, but to the fail of the
layout to get the right $selector (i was just explaining it in your issuer
report ;-)

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#9897 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

also, don't know if related with this PR, but in the content categories batch model when i select a operation the selectbox is hidden.

Update: sometimes it does sometimes don't, maybe it's my install.

So, @brianteeman you can set an unsuccessfull test for now, as @andrepereiradasilva is right, it will break again the batch modals...

BTW before the scroll was on the entire page - i discovered this issue when i was trying to write a PR that would make the left hand column scroll but keep the right hand column fixed

Yes it was scrolling, because in 3.5.0 RC, when BS modal was added, there was an issue with scrolling and i added a forced overflow-y: auto !important on modal-body.
This was not the best looking way to fix it, as in many cases, the scrolling appeared even if not needed.
That's why the redo for 3.5.2 (currently in staging).
But, this scrolling patch reveals now an other issue, with the way BS modal are implemented in com_templates not using the modal layouts (so the BS modal fix for scrolling can't work there, as not using the Joomla layouts...)...

So, i'm trying to check all this ;-)

Already changed my test on the tracker it just doesnt show on github

This PR has received new commits.

CC: @brianteeman

This PR has received new commits.

CC: @brianteeman

Thanks @brianteeman !

I have updated this PR to only the "display" issue (and not break Batch modal ;-) ), due to changes done few days ago in .nav classes by addition of clear:both needed as well for modal-footer to clear modal-body rendering.

About scrolling, it's another issue, due to hardcoded modals in com_templates, not using Joomla BS modals API (layouts).
I'm working as well on this change, which needs a bit of refactory.

Will do my best for a PR concerning this. ;-)

I have tested this item successfully on 95339d9

> About scrolling, it's another issue, due to hardcoded modals in com_templates, not using Joomla BS modals API (layouts).

I'm working as well on this change, which needs a bit of refactory.

So you will do another PR for that, right?

@andrepereiradasilva Exactly
I'm working on it: com_templates (admin) modals refactory, with new views, and a minor improvement in the same time for the modal layout (better detection if scroll is needed in modal) ;-)

I have tested this item successfully on 95339d9

Folder-Tree is now scrollable.

Folder-Tree is now scrollable.

@franz-wohlkoenig this PR needed to be tested on the last staging (due to last changes in .nav classes). As with only this change, it should not scroll... ;-)

But, i close here, to include this display fix in the com_templates refactory of modals, to allow loading of the JLayouts modal including the core hack script to fix BS modal. (easier to have only 1 PR to be tested for modal ;-) )

@brianteeman @andrepereiradasilva @franz-wohlkoenig :
So, close in favor of: #9908

@andrepereiradasilva @brianteeman i've created a PR to improve a bit the html structure of modals in template manager, and in the same time, did it to have a scrolling on left column for the list of files/folders : #10100
Maybe something you were thinking of ? ;-)