?
avatar richard67
richard67
13 Apr 2016

Steps to reproduce the issue

It seems that one of the commits on staging between 3.5.0 and 3.5.1 has removed file "media/mod_languages/images/si_lk.gif", which once has been renamed from "si_LK.gif" with following commit:

f283733.

This could have been caused by a contibutor or maintainer working on Windows, where renaming "si_LK.gif" to "si_lk.gif" does not really have an effect because of case-insensivity of filenames, and still having the "si_LK.gif" name when pushing a branch to github. Or maybe a Git/GitHub bug?

Expected result

On Linux with Joomla! 3.5.1 or staging in Joomla! root folder:

ls -al media/mod_languages/images/si_lk.gif

=> File exists.

Actual result

File does not exist.

System information (as much as possible)

OS = Linux, no other details relevant.

Additional comments

@infograf768 Can you check and report back if this really was by mistake or maybe was desired? And if mistake, who shall do a PR? Me? Or do you wanna do it?

@wilsonge Maybe you can check with which commit to staging the file has been removed, and maybe check back with the contributor to find out how that was caused and if such problems can be avoided somehow in future. I once noticed the commit and wanted to make an issue/PR but then later forgot it, and now I do not find it anymore. But I am almost sure that I remember it was not a pure merge of a PR, it was a commit based on a PR but made by you similar to when you do a "fixed in code base" (but am not sure if it had this label or not). Was somewhen between 3.5.0 release and 3.5.1 release.

avatar richard67 richard67 - open - 13 Apr 2016
avatar richard67 richard67 - change - 13 Apr 2016
Category Multilanguage
avatar andrepereiradasilva
andrepereiradasilva - comment - 13 Apr 2016
avatar richard67
richard67 - comment - 13 Apr 2016

Ah, yes, this was it, I remember now.

avatar brianteeman
brianteeman - comment - 13 Apr 2016

@C-Lodder you broke the internet


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9893.

avatar wojsmol
wojsmol - comment - 13 Apr 2016

Please test #9902

avatar brianteeman brianteeman - change - 13 Apr 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-04-13 17:57:53
Closed_By brianteeman
avatar brianteeman brianteeman - close - 13 Apr 2016
avatar brianteeman brianteeman - close - 13 Apr 2016
avatar C-Lodder
C-Lodder - comment - 13 Apr 2016

@brianteeman ...Are you sure you're not getting me muddled up with @wilsonge ?

avatar C-Lodder
C-Lodder - comment - 13 Apr 2016

I don't see any reference to images in my PR

avatar richard67
richard67 - comment - 13 Apr 2016

Let's say is was Microsoft's fault ... is always a good idea to assume this :smile:

avatar C-Lodder
C-Lodder - comment - 13 Apr 2016

@richard67 - Nah let's just say it was @wilsonge.....normally is anyway :P

avatar wojsmol
wojsmol - comment - 13 Apr 2016
avatar C-Lodder
C-Lodder - comment - 13 Apr 2016

@wojsmol - erm...oops :/

avatar mbabker
mbabker - comment - 13 Apr 2016

Stop spending so much time around @wilsonge as his tendency to break all the things is rubbing off on you.

avatar wilsonge
wilsonge - comment - 13 Apr 2016

Well as @C-Lodder is responsible for me being involved in Joomla in the first place I'm pretty sure he'll forever be in debt :D

avatar brianteeman
brianteeman - comment - 13 Apr 2016

Didn't George tell you - Brian is always right
On 13 Apr 2016 10:42 pm, "George Wilson" notifications@github.com wrote:

Well as @C-Lodder https://github.com/C-Lodder is responsible for me
being involved in Joomla in the first place I'm pretty sure he'll forever
be in debt :D


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9893 (comment)

Add a Comment

Login with GitHub to post a comment