? ? Pending

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
12 Apr 2016

Summary of Changes

very simple PR just to remove the dot in backend login panel "Go to site home page." link.

Testing Instructions

Go to the bottom of the backend login screen, there in a "Go to site home page." link, after patch the dot is removed.
Or just check code difference.

avatar andrepereiradasilva andrepereiradasilva - open - 12 Apr 2016
avatar andrepereiradasilva andrepereiradasilva - change - 12 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2016
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2016
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 12 Apr 2016

Personally its a sentence so needs the .

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Apr 2016

A link with a dot? How about just "View Site" like when you're logged in?

avatar brianteeman
brianteeman - comment - 12 Apr 2016

@chrisdavenport any thoughts?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9869.

avatar chrisdavenport
chrisdavenport - comment - 12 Apr 2016

Technically, it's a complete sentence in its own right, so it should have a full stop. But in this case it's being used purely as link text which just happens to be a full English sentence. As a link it certainly does look odd with the full stop, so I tend to agree with @andrepereiradasilva and I think it should be removed.

avatar brianteeman brianteeman - test_item - 12 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 12 Apr 2016

I have tested this item :white_check_mark: successfully on 5558da9


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9869.

avatar brianteeman brianteeman - change - 12 Apr 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 12 Apr 2016

RTC using @chrisdavenport as a successful test ;)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9869.

avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 12 Apr 2016
Category Language & Strings
avatar brianteeman brianteeman - change - 12 Apr 2016
Labels
avatar brianteeman brianteeman - change - 12 Apr 2016
Milestone Added:
avatar rdeutz rdeutz - reference | f7ee6d0 - 12 Apr 16
avatar rdeutz rdeutz - merge - 12 Apr 2016
avatar rdeutz rdeutz - close - 12 Apr 2016
avatar rdeutz rdeutz - change - 12 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-12 20:40:05
Closed_By rdeutz
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 12 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar brianteeman brianteeman - change - 11 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment