[#9850] - TemplateName fieldtype
- Closed
- 11 Apr 2016
- Medium
- Build: master
- # 9850
In the Templates Styles menu are two search filters
Location and Template
When location is set to admin the template filter only shows the admin templates
When location is set to site the template filter only shows the site templates
BUT
When location is not set the template filter only shows the site templates it should display all the templates
What does it show when NO location is set
On 11 April 2016 at 15:24, Thomas Hunziker notifications@github.com wrote:
It shows styles from admin and site for me as expected. Am I missing
something to reproduce the issue?—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#9850 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Can reproduce this on 3.5.1.
Hi, I checked this on 3.5.1. and @brianteeman is right. It does only show Admin templates. See the attached screen
Weird I cant replicate it now either
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9850.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-11 17:07:21 |
| Closed_By | ⇒ | brianteeman |
| Status | Closed | ⇒ | Confirmed |
| Closed_Date | 2016-04-11 17:07:21 | ⇒ | |
| Closed_By | brianteeman | ⇒ |
Sorry I am an idiot I retested the wrong site ;(
The issue is exactly as shown in the screenshot from @polakluk
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9850.
So, the fix is easy:
in file administrator/components/com_templates/helpers/templates.php, 2 lines have to be changes:
line 80:
from
public static function getTemplateOptions($clientId = '*')
to
public static function getTemplateOptions($clientId = null)
line 86
from:
if ($clientId != '*')
to
if ($clientId != null)
The other way to fix this is to set filter.client_id to '*' by default at all places in code which is, in my opinion, a bit of a overkill for this. What do you think?
I can create pull-request once I get back home.
andrepereiradasilva
-
Whatever you think is best
Ah, misunderstood the issue. I see it now as well.
Closing as we hace a PR
| Status | Confirmed | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-11 17:47:01 |
| Closed_By | ⇒ | Bakual |
It shows styles from admin and site for me as expected. Am I missing something to reproduce the issue?