? ? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
10 Apr 2016

Pull Request for Improvement.

Summary of Changes

com_checkin behaves in a different way than the other components.
If show the tables even if there are no items to check in.

This PR changes that to only show the tables that have items to check in.

Testing Instructions

  • Use latest staging
  • Open an article and don't save and/or close it (ex: change the url in the browser address bar to https://domain.tld/administrator/)
  • Go to "System -> Global Check-in" you will see something like this:

image

  • Apply patch with the patchtester
  • Go again to "System -> Global Check-in" you will now see something like this:

image

  • Select that table and press "Check-in"
  • You will now get a message like this

image

avatar andrepereiradasilva andrepereiradasilva - open - 10 Apr 2016
avatar andrepereiradasilva andrepereiradasilva - change - 10 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Apr 2016
Labels Added: ? ?
avatar brianteeman brianteeman - test_item - 10 Apr 2016 - Not tested
avatar brianteeman
brianteeman - comment - 10 Apr 2016

I have not tested this item.

Really like this


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9837.

avatar brianteeman brianteeman - test_item - 10 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 10 Apr 2016

I have tested this item :white_check_mark: successfully on 39a94b1

Really like this


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9837.

avatar brianteeman brianteeman - change - 10 Apr 2016
Category Administration UI/UX
avatar brianteeman brianteeman - change - 10 Apr 2016
The description was changed
Labels
avatar MATsxm MATsxm - test_item - 10 Apr 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 10 Apr 2016

I have tested this item :white_check_mark: successfully on 39a94b1

Works as described - Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9837.

avatar andrepereiradasilva
andrepereiradasilva - comment - 10 Apr 2016

thanks for testing @brianteeman @MATsxm

avatar brianteeman brianteeman - change - 10 Apr 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 10 Apr 2016

RTC
Simple but useful improvement


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9837.

avatar joomla-cms-bot joomla-cms-bot - change - 10 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 10 Apr 2016
Milestone Added:
avatar rdeutz rdeutz - change - 12 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-12 20:34:06
Closed_By rdeutz
avatar rdeutz rdeutz - reference | 9e8bbb1 - 12 Apr 16
avatar rdeutz rdeutz - merge - 12 Apr 2016
avatar rdeutz rdeutz - close - 12 Apr 2016
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 12 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar brianteeman brianteeman - change - 11 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment