Hi Cyril!

At first sight (haven't tested yet...) this looks like a solid implementation! Thanks!

Unhappily next week I'll be out and probably I would not have much time for testing. Let's see if I can do something tonight or tomorrow...

I don't have any "iAnything", nor Android smartphones for testing: just my oooold faithfull Blackberry, so I think my testing will be limited to desktop browsers.

Regards,

Sergio

P.S.: ... evoking @dgt41 in here, if not already done... Hi Dimitri!

Cyril,

I found some time to test this and it works: I've tested it against current staging using the Menu Batch modals and resizing my viewport using FF "Responsive Design View".

There is only one minor "glitch" that I don't know if you deem worth to be fixed or not: while resizing the viewport from BIG to small works perfectly (content is resized, internal scrollbar appears), when resizing from small to BIG the height of the internal div is not adjusted to the new available "real estate" and thus the internal scrollbar stays there. No big deal, but I thought you would like to know.

Let me know if you think you'll fix this too: in case I'll re-test, if not I'll give you my

I think more testing performed by people having access to real iOS devices is preferable...

Thanks again!

Thanks for test and feedback @smz !

There is only one minor "glitch" that I don't know if you deem worth to be fixed or not: while resizing the viewport from BIG to small works perfectly (content is resized, internal scrollbar appears), when resizing from small to BIG the height of the internal div is not adjusted to the new available "real estate" and thus the internal scrollbar stays there. No big deal, but I thought you would like to know.

So, you have resize your window, for testing purpose?
In real usage, not sure a user will open a modal, and then resize its window... ;-)

We could of course add a resize() handler and re-calculate height on resize, but there will be performance issue especially in IE and webkit browsers (Chrome, Safari...) many resize events fire as long as the user continues resizing the window. (not in FF or Opera, where event is fired at end of resizing).
We could add a timeout to the resize event to lower this effect, but still a bit of performance issue.

The fact is BS2 and BS3 modal has a built issue (nice looking, but not easy to manage in a responsive environnement...).

The main purpose here is just to be able to use the BS modal in all screen sizes (that is not possible on small screen with original BS modal).
In fact, a fix for BS modal, not a refactory ;-)

I don't have any "iAnything", nor Android smartphones for testing: just my oooold faithfull Blackberry, so I think my testing will be limited to desktop browsers.

All tests are welcomed! And... i don't have a Blackberry, so yours is needed!

All tests are welcomed! And... i don't have a Blackberry, so yours is needed!

hmm... I have to figure out how to convince my Blackberry to go to my dev environment in my LAN... I can't to do that simply by IP address as my dev environment hosts several sites, and I don't think my Blackberry has the equivalent of an /etc/hosts

I was thinking... would it be handy if I temporarily offer to you a cPanel on my VPS for testing that? I don't have the time to make a Joomla installation, but I can quickly create the cPanel, give you the access credentials and then you can manage to install Joomla on that and give Joomla admin rights to a few trusted testers... What do you think? This can eventually be done only tomorrow as by Monday I'll be on the go...

... and:

In real usage, not sure a user will open a modal, and then resize its window... ;-)

agreed!!

I have tested this item unsuccessfully on f1e0ab5

Modal Window stay to small in Height. You have to scrool in Window and Dropdown-List:

Test only on Mac/Firefox and stopp testing cause of Behaviour.

I have tested this item successfully on f1e0ab5

Tested on multiple browsers and devices - all good

@franz-wohlkoenig
1.did you clear the browser cache as there has been a css change
2. what happens when you click on the select boxes. It should look like this

@brianteeman Browser-Cache is cleared. A screen recording at https://youtu.be/SxfQaw8iP14 show what happens when click on select boxes.

Dont know what to say - the video shows the behaviour without th patch
applied. As you stated you were using firefox I just tried it. Went to
firefox tested batch - appears as in the video, applied patch and tested
batch - appears as in the batch - cleared browser cache and tested -
appears as in my screenshot

I have tested this item unsuccessfully on f1e0ab5

Changing my test result to failed.
@joomlic the pr fixes the modal but I discovered after applying it that all the admin submenus no longer appear

I have tested this item successfully on f1e0ab5

Test on Module, Menu

• Mac 10.11.4: Firefox45, Safari9.1, Chrome49
• Windows Server 2008: Firefox43, IE11

It works now cause i had forgot to reapply Patch.

@franz-wohlkoenig can you test the menu dropdown submenus AFTER applying the patch. For me they stopped working

@brianteeman which submenu? This?

I have tested this item unsuccessfully on f1e0ab5

Revert Test result like @brianteeman cause of lost of Submenues in Admin-Template.

@franz-wohlkoenig and @brianteeman, could you attach a screen shot of submenu issue, as i don't have issue, and not sure to understand which submenu dropdowns are missing ?...
Thanks!

@JoomliC

Submenu of

• "Manage" (should show "Add New User"),
• "Groups" (should show "Add New Group"), etc.

isn't shown after applying Patch:

no issues with sub-menus here... curious...

I've got it now too.
With the changes of this pr on my dev site, no issue, but on a site by applying the patch, i have it... :-|
Weird...

I don't... :-/
FF 45.0.1 Win 8.1 64

@JoomliC While you are there (I can see you coding and debugging!!) can you have a look at why the "close" (X) button doesn't works at small viewport sizes? That's not a problem (if it is a problem...) introduced by your patch: it was there before...

@brianteeman and @franz-wohlkoenig i think i've found why the issue with submenu!
If you apply the patch on 3.5.1 you will have a partial change for this #9375
This is why i didn't have issue on dev environnement (made this PR on staging) but have the submenu issue on a fresh 3.5.1 install.

When applying the PR on staging (as i've done on dev., and as @smz did) there's no issue with submenu for me.

Could you redo testing on staging ?

Thanks!

While you are there (I can see you coding and debugging!!) can you have a look at why the "close" (X) button doesn't works at small viewport sizes? That's not a problem (if it is a problem...) introduced by your patch: it was there before...

@smz the close cross "x" at top right of the modal ? I don't have issue with this, before and after patch...

@smz the close cross "x" at top right of the modal ? I don't have issue with this, before and after patch...

Yes, but (oh, gosh!) that happens only if you first open the modal and then resize it to a smaller viewport. I suppose we can disregard this...

I have tested this item successfully on f1e0ab5

Tested against "staging" using FF "Responsive Design View" on Windows 8.1 64bit
Everything OK, thanks!

Yes, but (oh, gosh!) that happens only if you first open the modal and then resize it to a smaller viewport. I suppose we can disregard this...

Not able to reproduce this... in which modal (could be a separated issue, due to a specific modal ;-) )

mod_menu com_menus, sorry

I have tested this item unsuccessfully on f1e0ab5

Same as before: No Submenues in Admin-Menue.

@smz with batch on com_menus ? or else... tested, but no issue...

@franz-wohlkoenig do you have tested against current staging ? As relative PR was merged 4 days ago.
If you test it on a staging older or 3.5.1 stable, you will have submenu issue
Thanks to confirm about the staging version used (today!) ;-)

@JoomliC actually my issue doesn't have anything to do with resize: sometimes it happens, sometimes not... both with and w/o your patch. Worst glitches to debug, I know... time dependend... :-/

If I were you I'd simply disregard and add this to the "Unexpected Expected Behaviours" list...

I have tested this item successfully on f1e0ab5

Tested with staging and all good

@JoomliC Update Channel is "Testing" > "no Updates available". So i'm on 3.5.1. New Data fetched, Cache cleared after Patch applied.

To get the lastest staging you need to download the full install from here
and install as a NEW site
https://github.com/joomla/joomla-cms/archive/staging.zip

On 10 April 2016 at 16:27, Franz Wohlkönig notifications@github.com wrote:

@JoomliC https://github.com/JoomliC Update Channel is "Testing" > "no
Updates available". So i'm on 3.5.1. New Data fetched, Cache cleared after
Patch applied.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9817 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

thanks @brianteeman, will report.

I have tested this item successfully on f1e0ab5

Submenues are shown also as the Dropdown-List in an Modal Window on Joomla! 3.5.2-dev

RTC

@brianteeman can you please tell me how to know when there is a new "latest staging" at https://github.com/joomla/joomla-cms/archive/staging.zip?

@franz-wohlkoenig every time there is a new pul request merged the link you have wlll generate a new copy of staging

thanks @brianteeman for Explanation.

Thanks @brianteeman @smz @franz-wohlkoenig for testing!

@franz-wohlkoenig to add an addtional info, there was an issue on 3.5.1 to apply this PR because one other PR was already merged in 3.5.2-dev (staging), including changes in Isis template.css.
This is not always the case, but by appling this PR on 3.5.1 and not on staging, the issue was a partial integration of the other PR (and so, was broken) ;-)

Thanks @JoomliC So its ok to test like now on 3.5.1. But if PR requier "latest staging" it means delete Testsite & install latest staging as new Site.

@franz-wohlkoenig or just to replace the current install files by staging files. ;-)

a ftp-upload is easier*g, thanks @JoomliC