? ? Pending

User tests: Successful: Unsuccessful:

avatar shubhamnba2009
shubhamnba2009
7 Apr 2016

Steps to reproduce

  1. Go to Administartor backend.
  2. Go to Users dropdown menu.
  3. Select User Note Category.

Expected Result

Add New User Note Category.

Actual Result

Add New Category.

Steps to test

  1. Apply the PR
  2. User Note Categories submenu will now be correct.
avatar shubhamnba2009 shubhamnba2009 - open - 7 Apr 2016
avatar shubhamnba2009 shubhamnba2009 - change - 7 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Apr 2016
Labels Added: ? ?
avatar shubhamnba2009 shubhamnba2009 - change - 7 Apr 2016
The description was changed
avatar shubhamnba2009 shubhamnba2009 - change - 7 Apr 2016
The description was changed
avatar brianteeman
brianteeman - comment - 7 Apr 2016

Am I looking in the wrong place as I dont see the problem that this PR is fixing
screen shot 2016-04-07 at 16 31 55

screen shot 2016-04-07 at 16 32 00


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9798.

avatar brianteeman brianteeman - change - 7 Apr 2016
Status Pending Information Required
Labels
avatar shubhamnba2009
shubhamnba2009 - comment - 7 Apr 2016

After adding PR it looks like this.

image


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9798.

avatar brianteeman
brianteeman - comment - 7 Apr 2016

OK so I was looking in the wrong place
I dont think this change is necessary. The existing string is clear enough

avatar brianteeman brianteeman - change - 7 Apr 2016
Status Information Required Pending
avatar brianteeman brianteeman - test_item - 7 Apr 2016 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 7 Apr 2016

I have tested this item :red_circle: unsuccessfully on 05f4c9b


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9798.

avatar shubhamnba2009
shubhamnba2009 - comment - 7 Apr 2016

Is this unsuccessful test due to PR not working properly or your diagreeing with PR?

avatar brianteeman
brianteeman - comment - 7 Apr 2016

disagreeing

On 7 April 2016 at 22:51, Shubham Rajput notifications@github.com wrote:

Is this unsuccessful test due to PR not working properly or your
diagreeing with PR?


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#9798 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar brianteeman brianteeman - change - 8 Apr 2016
Category Language & Strings Templates (admin)
avatar brianteeman brianteeman - change - 8 Apr 2016
Labels
avatar brianteeman
brianteeman - comment - 8 Apr 2016

Its also a fail as it doesnt have any effect in the hathor template


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9798.

avatar shubhamnba2009
shubhamnba2009 - comment - 8 Apr 2016

While checking it on hathor Template i found out that "Templates" and "Language" submenu option is not showing. Can you confirm it @brianteeman

pic


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9798.

avatar brianteeman
brianteeman - comment - 8 Apr 2016

that is correct - its a bug


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9798.

avatar brianteeman
brianteeman - comment - 10 Apr 2016

While checking it on hathor Template i found out that "Templates" and "Language" submenu option is not showing.

I have done a Pull Request for that #9823


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9798.

avatar joomla-cms-bot
joomla-cms-bot - comment - 10 Apr 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9798.

avatar shubhamnba2009
shubhamnba2009 - comment - 10 Apr 2016

Made changes in hathor template if anyone else agree's with this PR.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9798.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 11 Apr 2016 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Apr 2016

I have tested this item :white_check_mark: successfully on d9d9c6d

Tested on Isis & Hathor. But former "Add new Category" is clear.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9798.

avatar zero-24 zero-24 - change - 7 May 2016
Status Pending Needs Review
avatar zero-24
zero-24 - comment - 7 May 2016

I'm moving that on the Review List so we can have a decision here. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9798.

avatar brianteeman brianteeman - change - 7 May 2016
Status Needs Review Closed
Closed_Date 0000-00-00 00:00:00 2016-05-07 14:02:38
Closed_By brianteeman
Labels
avatar brianteeman brianteeman - change - 7 May 2016
Labels
avatar brianteeman brianteeman - close - 7 May 2016
avatar brianteeman
brianteeman - comment - 7 May 2016

Thank you for your contribution but it has been decided that this is not something that will be changed in the core of Joomla.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9798.

Add a Comment

Login with GitHub to post a comment