? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
7 Apr 2016

This is a redo of #4294

Summary of Changes

Right now if you want to include some custom fields in your plugin you need to include a custom field path in the relative xml file, something like:

<fieldset addfieldpath="/plugins/system/<plugin name>/field">

Documented here: https://docs.joomla.org/Creating_a_custom_form_field_type

This PR leverages this, so custom fields will happily reside inside a folder named field

Why field and not fields?
Singular word help us transition to autoload and namespace

Testing Instructions

Apply this patch with patch tester
Go to plugins tinyMCE and if you can see a dropdown for the skins you have a successful test:
screen shot 2016-04-08 at 00 00 21

Also go to Profile and check the Term of service and Date of birth, if dropdown then success:
screen shot 2016-04-08 at 00 00 05

Check the stats plugin and observe that all fields are correctly rendered/functioning

B/C

No backwards compatibility break

Performance

We just add one more folder check to the whole stack, so performance degradation should be unnoticeable. (Joomla itself does that hundreds of times for core libraries)

0ba9244 7 Apr 2016 avatar dgt41 init
avatar dgt41 dgt41 - open - 7 Apr 2016
avatar dgt41 dgt41 - change - 7 Apr 2016
Status New Pending
avatar brianteeman brianteeman - change - 7 Apr 2016
Category Fields Plugins
avatar joomla-cms-bot joomla-cms-bot - change - 7 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - test_item - 7 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 7 Apr 2016

I have tested this item :white_check_mark: successfully on 7bcedf1


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9796.

avatar joomla-cms-bot
joomla-cms-bot - comment - 7 Apr 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9796.

avatar brianteeman brianteeman - test_item - 7 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 7 Apr 2016

I have tested this item :white_check_mark: successfully on 5dbed46


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9796.

avatar MATsxm MATsxm - test_item - 7 Apr 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 7 Apr 2016

I have tested this item :white_check_mark: successfully on 5dbed46

Thanks :+1:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9796.

avatar brianteeman brianteeman - change - 8 Apr 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 8 Apr 2016

RTC - leaving it to the maintainers to decide the milestone


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9796.

avatar joomla-cms-bot joomla-cms-bot - change - 8 Apr 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 8 Apr 2016
Milestone Added:
avatar wilsonge wilsonge - close - 9 Apr 2016
avatar wilsonge
wilsonge - comment - 9 Apr 2016

Merged into 3.6.x with 6e4b192 - thanks @dgt41

avatar wilsonge wilsonge - change - 9 Apr 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-04-09 13:56:30
Closed_By wilsonge
avatar wilsonge wilsonge - close - 9 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 9 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 9 Apr 2016
Labels Removed: ?
avatar dgt41 dgt41 - head_ref_deleted - 4 May 2016
avatar wilsonge wilsonge - reference | dcb2ddb - 20 May 16
avatar infograf768
infograf768 - comment - 25 May 2016

@dgt41
regression in profile edit. see #10615

Add a Comment

Login with GitHub to post a comment