? ? Failure

User tests: Successful: Unsuccessful:

avatar dakuzen
dakuzen
7 Apr 2016

Pull Request for Issue #9547.

Merge JoomlaUpdate into Installer (beta)

Simplify Joomla Installation

Objectives

  • Eliminate the separation between com_joomlaupdate and com_installer, and deprecate the com_joomlaupdate component.
  • Work toward a simplification of the entire package installation and update classes and procedures.
  • Restrict changes to com_installer at this time to validate direction.

Assertions

  • Joomla! will benefit from the centralization & simplification of package management.
  • No insurmountable challenges prevent centralized installation logic for all packages.
  • Isolating the installer from runtime will allow for the future use of 3rd party package managers.

Approach

  • The standalone features in com_joomlaupdate has been merged into com_installer so that all installations and upgrades are processed using the forked installer and monitor. The same Akeeba restore code is still used, with a second Joomla! forked installer for non-core packages.

Testing Instructions

  • Create a Joomla! package containing a joomla.xml file and install using the extension installer.
  • Configure your Joomla! installation to pull core updates from a custom server, recreate the required xml files, and stage a customized Joomla! package containing the joomla.xml file, then perform an extension update.

Summary of Changes

  • Joomla! core updates were made visible in the Extension Update list.
  • All install and update controller events that performed installation were supplanted with logic to direct the procedure to a new installer controller.
  • A new installer controller and model were added that receive requests for single or batch installation.
  • The com_joomlaupdate monitor and standalone installer logic was ported into the new installer operation.
  • The Akeeba restore engine was ported and upgraded to support package folders.
  • A Joomla! standalone installer was created.

Issues & Considerations

  • During installation we are unpacking using a new InstallerModelInstall -> initialize operation that separates the previous unpacking and installation operations. The net result of this method is the set the package state value for the model and return true on success. This should be further compressed into the core JInstaller class.
  • The forked Joomla! installer that is launched for extension processing currently requires the Joomla! kernal / library.
  • The com_joomlaupdate features that deal with instructions and notification have not been ported. This could best be refactored into a standard for all packages to share, allowing updates and upgrade notices for all packages.
  • A standard for the installer provider needs to be defined along with considerations toward deprecating all JUpdate class operations into the JInstaller class.
  • Management of the forked installer should be controlled by the JInstaller class to eliminate dependency on the com_installer controller.
  • The JInstaller class dependencies need to be isolated & minized so that it can be included for standalone operations.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
2.00

avatar dakuzen dakuzen - open - 7 Apr 2016
avatar dakuzen dakuzen - change - 7 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Apr 2016
Labels Added: ? ?
avatar brianteeman brianteeman - change - 7 Apr 2016
Labels
avatar brianteeman brianteeman - change - 7 Apr 2016
Category Installation Language & Strings
avatar brianteeman
brianteeman - comment - 7 Apr 2016

Note to testers this can not be tested using com_patchtester


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9793.

avatar dakuzen
dakuzen - comment - 14 Apr 2016

@brianteeman I've not used the com_patchtester. Is there a specific change required to work with that component?

avatar brianteeman
brianteeman - comment - 14 Apr 2016

no its a limitation of that component not your code

On 14 April 2016 at 16:49, Dakuzen notifications@github.com wrote:

@brianteeman https://github.com/brianteeman I've not used the
com_patchtester. Is there a specific change required to work with that
component?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9793 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar joris85
joris85 - comment - 15 Apr 2016

I think this is a good idea!
I use Watchfully though but it nice to have things on one place.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9793.

avatar brianteeman brianteeman - change - 7 May 2016
Status Pending Needs Review
Labels
avatar brianteeman
brianteeman - comment - 7 May 2016

Setting to Needs Review before any more time is spent on this to see if this is a route that we want to go down or not.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9793.

avatar Kubik-Rubik
Kubik-Rubik - comment - 7 May 2016

Thank you for your suggestion but the PLT has decided that this is not something that we will include in the core of Joomla! at the moment after balancing the pros and cons.

avatar Kubik-Rubik Kubik-Rubik - change - 7 May 2016
Status Needs Review Closed
Closed_Date 0000-00-00 00:00:00 2016-05-07 16:03:09
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 7 May 2016
avatar joris85
joris85 - comment - 8 May 2016

Well there could be technical pros and cons i think.

But i think like a user and cant see any Cons.
Stuf on one place is just easier and i like easy.
If i update in jooma and extensions i am always a bit confused about the 2 different places and where to find the extensions update location (that difficult to find).

On my mac i also have 1 place for updates. Not one for my OS an one for my apps.

avatar dakuzen
dakuzen - comment - 9 May 2016

Out of curiosity @Kubik-Rubik, what are the "pros and cons" you levied in this decision?

avatar dakuzen
dakuzen - comment - 12 May 2016

I'm going to walk away from this but I will say it seems, as with mbabker's original rejection of this idea, that this is being dismissed for no reason other than an entrenchment with the recent separation agenda.

Add a Comment

Login with GitHub to post a comment