Feeling Lucky
?
?
[#9791] - Patch 9764
- Closed
- 3 Aug 2016
- Medium
- Build: staging
- # 9791
- Diff
- impleri:patch-9764
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #9764
Summary of Changes
Adjusted logic so that loadRenderer by default returns the generic renderer but also has a flag to return the media-specific renderer.
Testing Instructions
Tests were updated to assert both deprecated and new logic.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Category | ⇒ | Libraries Unit Tests |
| Labels | |||
brianteeman
- comment
- 3 Aug 2016
@impleri
Please can you respond to the comments from @mbbaker above and update this PR. If there is no response within a few weeks then we shall close this as it not mergeable right now. Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9791.
| Status | Pending | ⇒ | Information Required |
impleri
- comment
- 3 Aug 2016
Sorry. I've moved this client from Joomla. Since nobody else has an issue with the BC break, I'll close this.
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-03 20:33:12 |
| Closed_By | ⇒ | impleri | |
| Labels | |||
You need to add logic to the parser for jdoc tags for this new argument to
have any value in templates. Because it is ultimately those tags that
causes the loadRenderer call. Otherwise it adds nothing to the API.
On Thursday, April 7, 2016, Christopher Roussel notifications@github.com
wrote: