?
avatar bertmert
bertmert
7 Apr 2016

We wondered that we didn't get any email concerning update 3.5.0=>3.5.1 from plugin updatenotification.php (until today). Several sites and providers.
We checked email configurations, SuperUser settings and so on. All fine.
After some investigations we found out that for all these Joomlas cachetimeout is set to 0 (administrator/index.php?option=com_installer&view=update > Options button > Updates Caching (in hours)). Maybe the reason?
While debugging the plugin we saw that line https://github.com/joomla/joomla-cms/blob/staging/plugins/system/updatenotification/updatenotification.php#L115 (findUpdates(...)) always returns false.
We changed setting cachetimeout to 1 in two sites (absolutely identical configuration, same provider, same server, same email). 1 has sent an update notification meanwhile. The other one not.
For the first one we deleted JCH-Cache and Page-Cache. Don't know if this is anyhow related.

avatar bertmert bertmert - open - 7 Apr 2016
avatar brianteeman
brianteeman - comment - 7 Apr 2016

I wonder why it was set to 0 the default is 6

avatar brianteeman brianteeman - change - 7 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 7 Apr 2016
Labels Removed: ?
avatar brianteeman brianteeman - change - 7 Apr 2016
Labels Added: ?
avatar bertmert
bertmert - comment - 7 Apr 2016

Because we have set it to 0.

avatar brianteeman
brianteeman - comment - 7 Apr 2016

Well then I would say it is working a intended

On 7 April 2016 at 18:21, bertmert notifications@github.com wrote:

Because we have set it to 0.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#9789 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar wilsonge
wilsonge - comment - 7 Apr 2016

Cachetimeout of 0 has a special meaning in JUpdater. It means constantly refresh the update information every time you check. So it is actually a valid value. The problem is that we also perform a internal check

https://github.com/joomla/joomla-cms/blob/staging/plugins/system/updatenotification/updatenotification.php#L115

in the update notification plugin that will fail (0 will never be greater than the last run time vs the current time) - so the plugin won't run. I guess we need an edge case for the cache time being =< 0

avatar brianteeman brianteeman - change - 13 Apr 2016
Category Cache
avatar brianteeman brianteeman - change - 10 May 2016
Status New Confirmed
avatar bertmert bertmert - change - 12 Aug 2016
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2016-08-12 19:25:36
Closed_By bertmert
avatar bertmert bertmert - close - 12 Aug 2016
avatar zero-24
zero-24 - comment - 16 Aug 2016

@wilsonge

I guess we need an edge case for the cache time being =< 0

This would mean we send a mail per site request is that really we want? I think we should add a postinstall message that inform the users about that?

see: #11631

Add a Comment

Login with GitHub to post a comment