[#9778] - Fix handling of JMail error conditions
- Closed
- 12 Sep 2016
- Medium
- Build: staging
- # 9778
- Diff
- mbabker:Mail-Fixes
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
In an error condition JMail::Send() can return either a boolean false (if the site's mail function is turned off in the global config) or the result of JError::raiseNotice() (which is a JException object). This updates core to explicitly check for a boolean true return value (which is the only return on a successful send) instead of implicit checks for a boolean false or Exception object and also corrects an incorrect method reference (Exception does not have a getError() method).
Testing Instructions
Mainly review, otherwise validate that mail correctly sends in the changed methods AND error conditions are handled correctly.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Libraries |
| Category | Libraries | ⇒ | Administration Components Front End Installation Plugins |
I have tested this item
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9778.
This has fallen out of sync and I'm not interested in pursuing this anymore.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-12 20:50:08 |
| Closed_By | ⇒ | mbabker |
I have tested this item✅ successfully on 8828440
on code review. thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9778.