@tkuschel Please fix mentioned comment in PR and at the end there is an error of "No newline at end of file", fix this too.
So we can test it.

I've merged this PR to the staging and did fix the mentioned comments above. I'm a little confused about "No newline at end of file", because in the actual Joomla coding standard, you'll find a "Files should always end with a blank new line." see 3rd paragraph in https://developer.joomla.org/coding-standards/php-code.html

@zero-24 : I already deleted the spaces on line 170, with the second update today. Please check again 3649bb1

@zero-24 please test again, I already did your requested changes, thank you.

This behavior still exists in Joomla 3.7.1

I have tested this item ? unsuccessfully on a40b01e

The warnings/errors mentioned above are not shown any more but there are some warnings which may create errors for some reasons. Every attribute of a <div> should be distanced with a wide space from the others, e.g. in line 140 should be a space between _preview_img" and '. In line 141 is the same problem.

In common it is more comfortable to separate php and HTML-Code. Please avoid echo"<div>...</div>" or something like this. For example line 160-163 should stand in php-brackets instead of using echo. If this is not an option because you need the value of a php-variable you can use the shorter form of echo which is <?= $variable ?>. Line 160 to 163 can look like:

?>
<div class="media-preview add-on" style="height:auto">
<?= ' ' . $previewImgEmpty ?>
<?= ' ' . $previewImg ?>
</div>
<?php

If you try to write your code like this, you'll see that errors will be found more easily because HTML is clearly separated.

@Heggi93 please read the code style rules before giving that advice

I have tested this item ✅ successfully on a40b01e

Without patch:

• phpcs: Generic.Files.LineLength.TooLong: Line exceeds 150 characters; contains 217 characters
• phpcs: Generic.WhiteSpace.ScopeIndent.IncorrectExact: Line indented incorrectly; expected 1 tabs, found 0
• phpcs: Generic.Files.EndFileNewline.NotFound: File must end with a newline character
• Start tag () not closed properly, expected '>'.

With patch:
Warnings from above are resolved.

But no merge possible. Tested via com_patchtester.
@icampus

@Heggi93 can you please retest?

There are obvious errors in this patch.

@infograf768 you mean conflicting Files?

Not only. See comment above.

It has been a year since the last update and there are conflicts. I am going to close this at this time - it can always be reopened if updated