[#9738] - [searchtools] Integrate searchtools no results message in the searchtools layout
- Fixed in Code Base
- 12 Apr 2016
- Medium
- Build: staging
- # 9738
- Diff
- andrepereiradasilva:searchtools-improvement
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Improvement.
Summary of Changes
To make overrides simpler, this PR integrates the searchtools no results info in searchtools layout. This message is part of the searchtools so it should be there.
As a PoC i applied this only in com_cache cache view.
I also changed the background color of the searchtools no results message to be a info, not a warning. This change is only is the "new" layout, the "old" stays the same.
Advantage
- After this PR you can now change all the searchtools look (including no results info) with a simple layout override.
- You retain the ability to change the no result text by passing the
noResultsTextvariable to the layout.
Testing Instructions
- Use latest staging
- Apply patch
- Go to "System -> Clear cache" (clear the cache if exists)
- You will see a blue no results message.
- Now to test B/C go to any other view (articles for instance) and search for something that does not return results (you will see the "old" yellow message)
Observations
B/C is preserved as the old method continues to work fine.
If this gets to RTC state i intend to make the changes needed in all the other views.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
I have tested this item 
successfully on 158cec6
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9738.
| Category | ⇒ | Layout |
ehheheh. Don't make fun of my non native english mistakes! I would like to see you write in portuguese :)
I have tested this item successfully on 158cec6
Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9738.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-12 20:27:43 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
lol - pretend==> intend
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9738.