[#9732] - [system messages] Add new options for custom title and/or hide title
- Closed - No Reply
- 22 Jun 2017
- Medium
- Build: staging
- # 9732
- Diff
- andrepereiradasilva:messages-plus
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 0 Successful 1 Failed. Details
- Failure continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request Details
User tests: Successful: Unsuccessful:
Summary of Changes
The system messages are somewhat limited, since we can't change their title or even remove their title.
To solve this, this PR adds new options for system messages.
- Allows to hide the message title.
- Allows to add a custom title.
This PR also applies the changes need in all layouts (system, isis, protostar and beez3).
Testing Instructions
- Test if messages are working fine
- Then add the following code to the beggining of the
index.phpfile of the Joomla templates (protostar, beez3, isis and hathor):
JFactory::getApplication()->enqueueMessage('Test 1: Message without group (fallbacks to <code>message</code> group).');
JFactory::getApplication()->enqueueMessage('Test 2: Message in <code>error</code> group.', 'error');
JFactory::getApplication()->enqueueMessage('Test 3: Message in <code>notice</code> group.', 'notice');
JFactory::getApplication()->enqueueMessage('Test 4: Message in <code>warning</code> group.', 'warning');
JFactory::getApplication()->enqueueMessage('Test 5: Message in <code>message</code> group (will be in the same queue as test 1).', 'message');
JFactory::getApplication()->enqueueMessage('Test 6: Message in <code>message without title</code> group.', 'message', array('showTitle' => false));
JFactory::getApplication()->enqueueMessage('Test 7: Message in <code>notice with custom title</code> group.', 'notice', array('customTitle' => 'My custom title'));
JFactory::getApplication()->enqueueMessage('Test 8: Message in <code>notice with custom title</code> group (message 2).', 'notice', array('customTitle' => 'My custom title'));- Check if the result is something like this (please not that in beez3 there is no message title):
An effort was made to preserve B/C with existent layout overwrites. You should also test this patch in a custom template that has a message layout override (in /templates/<template-name>/html/layouts/joomla/system/message.php) (or use the one of in isis without this PR changes).
Note that before this patch this messages would look like this:
Observations
@mbabker i had to change JDocumentRendererHtmlMessage and enqueueMessage (normal and legacy) to make this work with the new options, please check if everything is fine with this changes.
Any suggestions and/or improvements are welcomed.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
The test is checking the returns from getMessageQueue since there is a B/C handler with adding messages to the message queue when calling the redirect method. So any of the tests validating that behavior you'll need to add the new options array to the expectation.
Should be fine now that you have the comma in there 
eheheh :) thanks a lot
| Labels | |||
| Category | ⇒ | Layout Templates (admin) |
I have tested this item 
successfully on 7b9e068
TEST OK
(J3.5.1, PHP 7)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9732.
I have tested this item successfully on 7b9e068
Tested successfully on protostar, tested without B/C issues on a Warp Template.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9732.
I have tested this item successfully on 7b9e068
Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9732.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
RTC thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9732.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Needs Review |
| Labels | |||
Setting to needs review. I wanna sit down and think about whether serialzing the data is the right choice here (my gut is that it isn't but I'm at the end of a long day so could be just not thinking straight!)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9732.
| Labels |
Removed:
?
|
||
i don't like it either, but i didn't find another way without creating a new message queue and preserving B/C. But please review when you have time. If you find a better method is fine by me.
| Milestone |
Added: |
||
OK. This is a 3.6 feature anyhow - but I promise I will look over it - hopefully over the next week or so - but if not @brianteeman is going to force me to have reviewed all the Needs Review issues in the next 3 weeks
| Labels |
Removed:
?
|
||
| Labels |
Added:
?
|
||
@andrepereiradasilva Can you please fix the merge conflict? Thank you.
| Status | Needs Review | ⇒ | Information Required |
| Labels | |||
| Labels |
Added:
?
|
||
@wilsonge can we move this to RTC now if @andrepereiradasilva get the merge conflicts fixed?
Yeah do it
| Status | Information Required | ⇒ | Pending |
| Labels | |||
@andrepereiradasilva can you fix the merge conflicts please and then this can be merged
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9732.
This PR has received new commits.
CC: @designbengel, @MATsxm, @mikeveeckmans
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9732.
don't test yet
This PR has received new commits.
CC: @designbengel, @MATsxm, @mikeveeckmans
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9732.
hum all seems fine but i get this notices/warning when appling the patch, after that all seem fine
Notice: Undefined index: options in /path/to/joomla-staging/libraries/joomla/document/renderer/html/message.php on line 89
Warning: array_replace(): Argument #1 is not an array in /path/to/joomla-staging/libraries/joomla/document/renderer/html/message.php on line 89
Probably because the patchtester send a message (Github api limit) to the before patch queue system and render it in the after patch system?
Don't have much time to look into it now. So if anyone can see if this is a problem that will exist on update please say.
| Milestone |
Removed: |
||
| Category | Layout Templates (admin) | ⇒ | Layout Templates (admin) Unit Tests |
| Labels | |||
@andrepereiradasilva you can avoid that by adding your github credentials to the patchtester options.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9732.
Tested ok in isis, protostar and hathor but in beez its not quite correct
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9732.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9732.
| Status | Pending | ⇒ | Information Required |
| Labels | |||
@andrepereiradasilva can you look at the beez issue please and then we can get this tested and merged
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/9732.
| Labels |
Removed:
?
?
?
|
||
| Category | Layout Templates (admin) Unit Tests | ⇒ | Administration Templates (admin) Layout Libraries Front End Templates (site) Unit Tests |
we have aslo conflicts here ;)
This PR needs a new owner or it will have to be closed as abandoned.
If this PR get no Response, it will be closed at 22th June 2017.
| Status | Information Required | ⇒ | Closed - No Reply |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-22 03:57:44 |
| Closed_By | ⇒ | franz-wohlkoenig |
closed as stated above.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/9732.
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/9732
@mbabker can you give a little help here?
what does this mean?