? ? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
4 Apr 2016

Pull Request for new Issue.

Summary of Changes

This PR is to remove PHP warnings when a language XML meta file is not found.

Before patch

image

After patch

image

Testing Instructions

  1. Use 3.5.0 or latest staging
  2. Install a second language (ex: fr-FR)
  3. Go to /language folder and rename the fr-FR directory to anything you like.
  4. In Joomla admin, go to `Extensions -> Language(s) -> Installed" you will get the PHP warning.
  5. Apply patch.
  6. Repeat step 4, you will get a joomla warning message. (you can now rename the folder back to the is original name)

Note: the same check if the xml file exists is made in JInstaller::parseXMLInstallFile()

avatar andrepereiradasilva andrepereiradasilva - open - 4 Apr 2016
avatar andrepereiradasilva andrepereiradasilva - change - 4 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Apr 2016
Labels Added: ? ?
avatar andrepereiradasilva andrepereiradasilva - change - 4 Apr 2016
The description was changed
avatar MATsxm MATsxm - test_item - 4 Apr 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 4 Apr 2016

I have tested this item :white_check_mark: successfully on 46b472f

Able to reproduce then #9730 works as decribed - Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9730.

avatar brianteeman brianteeman - change - 5 Apr 2016
Category Multilanguage
avatar brianteeman brianteeman - change - 5 Apr 2016
Labels
avatar brianteeman brianteeman - change - 5 Apr 2016
Category Multilanguage Language & Strings Multilanguage
avatar brianteeman brianteeman - test_item - 5 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 5 Apr 2016

I have tested this item :white_check_mark: successfully on 46b472f

Tested site and admin languages


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9730.

avatar brianteeman brianteeman - change - 5 Apr 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 5 Apr 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9730.

avatar joomla-cms-bot joomla-cms-bot - change - 5 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 5 Apr 2016
Milestone Added:
avatar rdeutz rdeutz - reference | fa8eaf5 - 12 Apr 16
avatar rdeutz rdeutz - merge - 12 Apr 2016
avatar rdeutz rdeutz - close - 12 Apr 2016
avatar rdeutz rdeutz - change - 12 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-12 20:23:45
Closed_By rdeutz
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 12 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar brianteeman brianteeman - change - 11 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment