Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#9723] - [com_templates] Only show enabled templates in templates view

? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
4 Apr 2016

Pull Request for new Issue.

Summary of Changes

When you have a template disabled (e.g. beez3) although the template doesn't appear in Extensions -> Templates -> Styles, it appears in Extensions -> Templates -> Templates.

To solve this issue, this simple PR adds a additional where to the com_templates templates model query.

Testing Instructions

Fast test

Experience developer can check code difference.

Normal test
  1. Use 3.5.0 or latest staging
  2. Go to Extensions -> Manage -> Manage, filter by Type = Template and disable beez3 and hathor.
  3. Now go to Extensions -> Templates -> Styles and check that hathor and beez3 are not there.
  4. Now go to Extensions -> Templates -> Templates and check that hathor and beez3 ARE there.
  5. Apply this patch
  6. Repeat steps 2 to 4 and check that hathor and beez3 ARE NOT there.
avatar andrepereiradasilva andrepereiradasilva - open - 4 Apr 2016
avatar andrepereiradasilva andrepereiradasilva - change - 4 Apr 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Apr 2016
Labels Added: ?
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 4 Apr 2016 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Apr 2016

I have tested this item :white_check_mark: successfully on 3b694f0

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9723.

avatar brianteeman brianteeman - change - 4 Apr 2016
Easy No ⇒ Yes
avatar brianteeman brianteeman - change - 4 Apr 2016
Category ⇒ Templates (admin) Templates (site) UI/UX
avatar brianteeman brianteeman - test_item - 4 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 4 Apr 2016

I have tested this item :white_check_mark: successfully on 3b694f0

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9723.

avatar brianteeman brianteeman - change - 4 Apr 2016
Status Pending ⇒ Ready to Commit
avatar brianteeman
brianteeman - comment - 4 Apr 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9723.

avatar joomla-cms-bot joomla-cms-bot - change - 4 Apr 2016
Labels Added: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 4 Apr 2016

fast RTC :)
thanks for testing @franz-wohlkoenig @brianteeman

avatar wilsonge wilsonge - change - 12 Apr 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-04-12 22:14:50
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 12 Apr 2016
avatar wilsonge wilsonge - merge - 12 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 12 Apr 2016
avatar wilsonge wilsonge - reference | 13e6523 - 12 Apr 16
avatar wilsonge wilsonge - merge - 12 Apr 2016
avatar wilsonge wilsonge - close - 12 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2016
Labels Removed: ?
avatar wilsonge wilsonge - change - 12 Apr 2016
Milestone Added:
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 12 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment