? Success
Pull Request for # 9697

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
1 Apr 2016

Steps to reproduce the issue

create a jform xml definition with two editor fields
for example open file administrator/components/com_content/models/article.xml
Add a new field nodes in the first fieldset above the field with name "articletext"
< field name="test1" type="editor"
label="Editor_No_Module_Pagebreak"
filter="JComponentHelper::filterText" buttons="true" hide="module,pagebreak" />
Make sure that tinymce is default editor on the Joomla! installation.
Open file administrator\components\com_content\views\article\tmpl\edit.php and replace

<?php echo $this->form->getInput('articletext'); ?>at line 88
with
<?php echo $this->form->getInput('test1'); ?>
<?php echo $this->form->getInput('articletext'); ?>
in order to display the new editor field in article edit form.

Open an article in the edit view in the administration

Expected result

Display two editor fields in the article edit view. The first one having the editor xtd buttons article, image and readmore, the second one having the editor xtd buttons article, image, readmore, module and pagebreak

Actual result

Both editor fields have the same editor xtd buttons (article, iamge and read more).

Testing

Apply patch and re try the above code

avatar dgt41 dgt41 - open - 1 Apr 2016
avatar dgt41 dgt41 - change - 1 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Apr 2016
Labels Added: ?
avatar ggppdk
ggppdk - comment - 1 Apr 2016

The editor buttons now work properly for tinymce, but all textareas still show the same buttons

avatar ggppdk
ggppdk - comment - 1 Apr 2016

My comment about same buttons shown is wrong, i have not tested it yet (but i have tested that buttons now work properly with multiple textareas)

avatar dgt41
dgt41 - comment - 1 Apr 2016

but i have tested that buttons now work properly with multiple textareas

That was the point of this PR

avatar ggppdk
ggppdk - comment - 1 Apr 2016

@dgt41
you are right

furthermore, i looked at the code,

  • using different editor buttons for tinymce is not implemented

i knew it was not,

but i got the impression this was implemented at some point (recently) because of the comments in #9697,
so the comment about "same buttons" in it, is wrong because this was never implemented for tinymce ?

avatar dgt41
dgt41 - comment - 1 Apr 2016

@ggppdk we can fix that easily:
screen shot 2016-04-02 at 02 27 20

To @all testers:

Please make sure that this DOES NOT introduce some B/C break

avatar ggppdk
ggppdk - comment - 1 Apr 2016

Yes, with 74a161d
different buttons are shown for each textarea

avatar avjoomla
avjoomla - comment - 2 Apr 2016

Hi thanks,

I tested with 74a161d and it solved the issue.

Regards,
Aicha

avatar brianteeman brianteeman - change - 2 Apr 2016
Rel_Number 0 9697
Relation Type Pull Request for
avatar brianteeman brianteeman - change - 2 Apr 2016
Category Fields
avatar brianteeman brianteeman - change - 2 Apr 2016
Category Fields Fields Plugins
avatar brianteeman brianteeman - change - 2 Apr 2016
Title
Fix for issue ##9697
Use two editor fields with different editor xtd buttons in one form
avatar brianteeman brianteeman - change - 2 Apr 2016
Title
Fix for issue ##9697
Use two editor fields with different editor xtd buttons in one form
avatar dgt41
dgt41 - comment - 24 Apr 2016

@avjoomla @ggppdk can you mark your tests in issues.joomla.org ? Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9707.

avatar brianteeman
brianteeman - comment - 24 Apr 2016

Its ok I will do it


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9707.

avatar brianteeman brianteeman - alter_testresult - 24 Apr 2016 - avjoomla: Tested successfully
avatar brianteeman brianteeman - alter_testresult - 24 Apr 2016 - ggppdk: Tested successfully
avatar brianteeman brianteeman - change - 24 Apr 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 24 Apr 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9707.

avatar joomla-cms-bot joomla-cms-bot - change - 24 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 24 Apr 2016
Milestone Added:
avatar ggppdk
ggppdk - comment - 24 Apr 2016

Sorry i did not post through the issue tracker at the time

Please note that this fix is good
but it fixes tinymce only,
it does not fix other editors

just saying , thanks for the fix !

avatar dgt41
dgt41 - comment - 24 Apr 2016

@ggppdk it's down to the plugin of each editor to be specific to each id, thus, I guess, we can only try to patch code mirror as the rest are 3pd code...

avatar rdeutz rdeutz - change - 25 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-25 08:17:18
Closed_By rdeutz
avatar rdeutz rdeutz - close - 25 Apr 2016
avatar rdeutz rdeutz - merge - 25 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 25 Apr 2016
avatar rdeutz rdeutz - reference | f9e0c00 - 25 Apr 16
avatar rdeutz rdeutz - merge - 25 Apr 2016
avatar rdeutz rdeutz - close - 25 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2016
Labels Removed: ?
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment