? Success
Pull Request for # 5643

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
1 Apr 2016

Pull Request for Issue #5643.

Summary of Changes

This PR is for solving one of issue with 16 months.
In the admin panel, you can't see the Info/error/success messages on mopbile and tablet view when you're in a view that have a sidebar.

Testing Instructions

  1. Use latest staging
  2. Resize browser window to mobile xs size
  3. Do any action on a view with admin sidebar that returns a message (ex: edit a user and press save and close)
  4. Result: You CAN'T see the success message. image
  5. Apply this patch
  6. Repeat steps 2 and 3
  7. Result: You CAN see the success message. image
avatar andrepereiradasilva andrepereiradasilva - open - 1 Apr 2016
avatar andrepereiradasilva andrepereiradasilva - change - 1 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 1 Apr 2016
Rel_Number 0 5643
Relation Type Pull Request for
avatar brianteeman brianteeman - change - 1 Apr 2016
Category Templates (admin)
avatar mikeveeckmans mikeveeckmans - test_item - 2 Apr 2016 - Tested successfully
avatar mikeveeckmans
mikeveeckmans - comment - 2 Apr 2016

I have tested this item :white_check_mark: successfully on 99b3c6a

TEST OK

(on iphone 6 , FF & Chrome )


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9703.

avatar infograf768
infograf768 - comment - 2 Apr 2016

Looks like you did not run the generate.css CLI as, if you had done, template-rtl.css would also have been modified.

avatar andrepereiradasilva
andrepereiradasilva - comment - 2 Apr 2016

i didn't.
made the changes manually
will change rtl css too them

avatar brianteeman brianteeman - test_item - 2 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 2 Apr 2016

I have tested this item :white_check_mark: successfully on 99b3c6a

Seems to work fine - once you fix the RTL and the less this can be RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9703.

avatar joomla-cms-bot
joomla-cms-bot - comment - 2 Apr 2016

This PR has received new commits.

CC: @brianteeman, @mikeveeckmans


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9703.

avatar andrepereiradasilva
andrepereiradasilva - comment - 2 Apr 2016

RTL css done.

avatar brianteeman brianteeman - test_item - 2 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 2 Apr 2016

I have tested this item :white_check_mark: successfully on 477863c


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9703.

avatar mikeveeckmans mikeveeckmans - test_item - 2 Apr 2016 - Tested successfully
avatar mikeveeckmans
mikeveeckmans - comment - 2 Apr 2016

I have tested this item :white_check_mark: successfully on 477863c

Tested on iphone6 , LTR and RTL .
TEST OK


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9703.

avatar brianteeman brianteeman - change - 2 Apr 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 2 Apr 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9703.

avatar joomla-cms-bot joomla-cms-bot - change - 2 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 2 Apr 2016
Milestone Added:
avatar andrepereiradasilva
andrepereiradasilva - comment - 2 Apr 2016

@mikeveeckmans @brianteeman thanks for testing

avatar wilsonge
wilsonge - comment - 6 Apr 2016

I found this bug modifying the downloads page earlier :laughing: - glad it's fixed :)

avatar wilsonge wilsonge - close - 6 Apr 2016
avatar wilsonge wilsonge - merge - 6 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 6 Apr 2016
avatar wilsonge wilsonge - reference | d97fb58 - 6 Apr 16
avatar wilsonge wilsonge - merge - 6 Apr 2016
avatar wilsonge wilsonge - close - 6 Apr 2016
avatar wilsonge wilsonge - change - 6 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-06 22:40:58
Closed_By wilsonge
avatar joomla-cms-bot joomla-cms-bot - change - 6 Apr 2016
Labels Removed: ?
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 6 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment