[#9696] - Regression: Wrong redirect after login when session expires —menu items and Content Languages
- Fixed in Code Base
- 6 Apr 2016
- Medium
- Build: staging
- # 9696
- Diff
- infograf768:session_redirect
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #9687
This PR to solve the Fatal error when editing a menu item and session expires.
It also solves the issue when editing a Content Language and session expires (before patch it redirects to Languages Installed)
Testing Instructions
Set your session to 1 minute.
Edit these items and wait session expires, then login.
Patch and test again.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Title |
|
||||||
I have tested this item 
successfully on 9194bf9
This PR solves the issue of the fatal error for both menu editing and content language editing. However I do think that these edit screens should never expire as the session alive should be used here. This fix at least solves the fatal error.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9696.
I have tested this item successfully on 9194bf9
able to reproduce then #9696 works as described with no fatal error for both menu editing and content language editing.
Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9696.
| Status | Pending | ⇒ | Ready to Commit |
| Category | ⇒ | Components |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
For me keepalive is a seperate issue
As for 3.5.1 I dont think we should add something at this time
On 1 April 2016 at 16:55, infograf768 notifications@github.com wrote:
not sure we should rtc, and not sure either this issue should not be
solved for 3.5.1 stable.
if keepalive is preferred, let's do it.@wilsonge https://github.com/wilsonge please decide
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#9696 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
i think with or without keepalive this should be merged.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-06 08:46:52 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
rdeutz
- | Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
@roland-d @andrepereiradasilva @javigomez
@wilsonge
All other core components do not create errors. They eventually redirect to the manager instead of the edited item while the items concerned here do redirect to the item edited.