[#9687] - Fatal error when editing menu item where session expired
- Closed
- 1 Apr 2016
- Medium
- Build: master
- # 9687
Steps to reproduce the issue
- Edit a menu item
- Do not touch the page until your session has expired (it may be useful to set the session to 1 minute)
- Click on the Save & Close button
- You now get the login page since session expired
- Login
- Login again as needed
- You now get a Fatal error: Call to a member function getGroup() on a non-object in D:\wamp\www\joomla-cms\layouts\joomla\searchtools\default\bar.php on line 28
Alternatively you can use a direct URL after being logged in to the administrator section:
http://domain/administrator/index.php?option=com_menus&layout=edit&id=233
Replace domain with your own domain and id, with an existing ID.
Expected result
That I get the page to edit the menu item.
Actual result
A page with notices and a fatal error. Only way to continue is to manually modify the URL to go to the homepage a the backend and then a navigate to the menu item and edit it.
System information (as much as possible)
Joomla! 3.5.1-rc Release Candidate [ Unicorn ] 28-March-2016 22:30 GMT
PHP 5.5.14 / PHP 7.0.4
Additional comments
Can anyone else confirm this?
Votes
@andrepereiradasilva Sounds similar huh but in the other PR you don't even have to wait till the session is expired. Now this gave me another idea, using this URL directly also generates the fatal error:
http://localhost/joomla-cms/administrator/index.php?option=com_menus&layout=edit&id=233
So yeah I would say it is basically the same but only for menus.
Tested, I was able to reproduce.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9687.
| Status | New | ⇒ | Confirmed |
I have a solution that would have to be done all over as I also tested it with Content Languages where the redirection after logging was not creating Errors but was to the installed languages Manager.
Change in ROOT/administrator/components/com_menus/views/item/tmpl/edit.php
<form action="<?php echo JRoute::_('index.php?option=com_menus&layout=edit&id=' . (int) $this->item->id); ?>" method="post" name="adminForm" id="item-form" class="form-validate">
to
<form action="<?php echo JRoute::_('index.php?option=com_menus&view=item&layout=edit&id=' . (int) $this->item->id); ?>" method="post" name="adminForm" id="item-form" class="form-validate">
i.e. add &view=item
For Content languages:
from
<form action="<?php echo JRoute::_('index.php?option=com_languages&layout=edit&lang_id=' . (int) $this->item->lang_id); ?>" method="post" name="adminForm" id="language-form" class="form-validate form-horizontal">
to
<form action="<?php echo JRoute::_('index.php?option=com_languages&view=language&layout=edit&lang_id=' . (int) $this->item->lang_id); ?>" method="post" name="adminForm" id="language-form" class="form-validate form-horizontal">
i.e. add &view=language
We can do this all over core when necessary, but what about 3rd party?
Please test #9696
@roland-d @andrepereiradasilva @javigomez
Closed
| Status | Confirmed | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-01 13:17:19 |
| Closed_By | ⇒ | brianteeman |
isn't this something like this one? #9371