? Pending

User tests: Successful: Unsuccessful:

avatar ucfnet002
ucfnet002
31 Mar 2016

Pull Request for Issue # .

Summary of Changes

Moved ".modal-body {" into mediaquery "@media (max-width: 767px)" in less-file of "isis"-template

Testing Instructions

in a menu, or content window select some items then click batch attempt to "move or copy" you will find the window is too small.
Apply this patch
repeat the test and on a standard screen it overflows correctly to allow you to select an item.
If possible test on multiple view ports particularly if you have a device has the max-width as above.
Not sure if it would be better removing it from the constraint totally.

avatar ucfnet002 ucfnet002 - open - 31 Mar 2016
avatar ucfnet002 ucfnet002 - change - 31 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Mar 2016
Labels Added: ?
avatar infograf768
infograf768 - comment - 31 Mar 2016

Have not tested but this patch is incomplete as generate.css has not been ran.
If I run php build/generatecss.php today, I get:

diff --git a/administrator/templates/isis/css/template-rtl.css b/administrator/templates/isis/css/template-rtl.css
index 99a336c..bc30e25 100644
--- a/administrator/templates/isis/css/template-rtl.css
+++ b/administrator/templates/isis/css/template-rtl.css
@@ -8171,8 +8171,8 @@
        padding: 5px 0;
    }
-}
-.modal-body {
-   -webkit-overflow-scrolling: touch;
-   overflow-y: auto !important;
+   .modal-body {
+       -webkit-overflow-scrolling: touch;
+       overflow-y: auto !important;
+   }
 }
 .pull-right {
diff --git a/administrator/templates/isis/css/template.css b/administrator/templates/isis/css/template.css
index ba425fb..bad66c4 100644
--- a/administrator/templates/isis/css/template.css
+++ b/administrator/templates/isis/css/template.css
@@ -2791,5 +2791,5 @@
 }
 .alert h4 {
-  margin: 0 0 .5em;
+   margin: 0 0 .5em;
 }
 .alert .close {
@@ -8171,7 +8171,7 @@
        padding: 5px 0;
    }
-}
-.modal-body {
-   -webkit-overflow-scrolling: touch;
-   overflow-y: auto !important;
+   .modal-body {
+       -webkit-overflow-scrolling: touch;
+       overflow-y: auto !important;
+   }
 }
diff --git a/administrator/templates/isis/less/template.less b/administrator/templates/isis/less/template.less
index 0b1a3d4..c5166af 100644
--- a/administrator/templates/isis/less/template.less
+++ b/administrator/templates/isis/less/template.less
@@ -1324,9 +1324,9 @@
        padding: 5px 0;
    }
-}

-/* Fix iOS scrolling inside bootstrap modals (using iframe) */
-.modal-body {
-   -webkit-overflow-scrolling: touch;
-   overflow-y: auto !important;
+   /* Fix iOS scrolling inside bootstrap modals (using iframe) */
+   .modal-body {
+       -webkit-overflow-scrolling: touch;
+       overflow-y: auto !important;
+   }
 }
diff --git a/templates/protostar/css/template.css b/templates/protostar/css/template.css
index cbc9db4..ff08400 100644
--- a/templates/protostar/css/template.css
+++ b/templates/protostar/css/template.css
@@ -2806,5 +2806,5 @@
 }
 .alert h4 {
-  margin: 0 0 .5em;
+   margin: 0 0 .5em;
 }
 .alert .close {
avatar ucfnet002
ucfnet002 - comment - 31 Mar 2016

sorry, didn't knew that. was my first submit to the joomla project.

avatar brianteeman
brianteeman - comment - 31 Mar 2016

I made the same comment in #9586

avatar ucfnet002
ucfnet002 - comment - 31 Mar 2016

brian, i saw your comment and so i decided to make this pull request. maybe it was a wrong way?

avatar brianteeman brianteeman - change - 31 Mar 2016
Category Templates (admin)
avatar wojsmol
wojsmol - comment - 31 Mar 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 31 Mar 2016

@wojsmol i think you made the patch in wrong branch (ucfnet002:staging) when it should be the ucfnet002:patch-1 branch

avatar wojsmol
wojsmol - comment - 31 Mar 2016

@aaleksanyants thank you - fixed

avatar andrepereiradasilva andrepereiradasilva - test_item - 31 Mar 2016 - Tested unsuccessfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 31 Mar 2016

I have tested this item :red_circle: unsuccessfully on 92df354

Works fine on desktop and tablet but not on mobile XS viewport.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9683.

avatar Twincarb
Twincarb - comment - 31 Mar 2016

The comment held in the less file is as below, I was to busy to amend and test a correct solution.

Fix iOS scrolling inside bootstrap modals (using iframe) */

The testing of this PR would also need to take this into consideration. Was to busy to update the previous PR, and to investigate the reason for the original change.

Possible changes to the code will need to be :

/* ----------- iPhone 4 and 4S ----------- */

/* Portrait and Landscape */
@media only screen
and (min-device-width: 320px)
and (max-device-width: 480px)
and (-webkit-min-device-pixel-ratio: 2) {

}

/* Portrait */
@media only screen
and (min-device-width: 320px)
and (max-device-width: 480px)
and (-webkit-min-device-pixel-ratio: 2)
and (orientation: portrait) {
}

/* Landscape */
@media only screen
and (min-device-width: 320px)
and (max-device-width: 480px)
and (-webkit-min-device-pixel-ratio: 2)
and (orientation: landscape) {

}

/* ----------- iPhone 5 and 5S ----------- */

/* Portrait and Landscape */
@media only screen
and (min-device-width: 320px)
and (max-device-width: 568px)
and (-webkit-min-device-pixel-ratio: 2) {

}

/* Portrait */
@media only screen
and (min-device-width: 320px)
and (max-device-width: 568px)
and (-webkit-min-device-pixel-ratio: 2)
and (orientation: portrait) {
}

/* Landscape */
@media only screen
and (min-device-width: 320px)
and (max-device-width: 568px)
and (-webkit-min-device-pixel-ratio: 2)
and (orientation: landscape) {

}

/* ----------- iPhone 6 ----------- */

/* Portrait and Landscape */
@media only screen
and (min-device-width: 375px)
and (max-device-width: 667px)
and (-webkit-min-device-pixel-ratio: 2) {

}

/* Portrait */
@media only screen
and (min-device-width: 375px)
and (max-device-width: 667px)
and (-webkit-min-device-pixel-ratio: 2)
and (orientation: portrait) {

}

/* Landscape */
@media only screen
and (min-device-width: 375px)
and (max-device-width: 667px)
and (-webkit-min-device-pixel-ratio: 2)
and (orientation: landscape) {

}

/* ----------- iPhone 6+ ----------- */

/* Portrait and Landscape */
@media only screen
and (min-device-width: 414px)
and (max-device-width: 736px)
and (-webkit-min-device-pixel-ratio: 3) {

}

/* Portrait */
@media only screen
and (min-device-width: 414px)
and (max-device-width: 736px)
and (-webkit-min-device-pixel-ratio: 3)
and (orientation: portrait) {

}

/* Landscape */
@media only screen
and (min-device-width: 414px)
and (max-device-width: 736px)
and (-webkit-min-device-pixel-ratio: 3)
and (orientation: landscape) {

}


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9683.

avatar ucfnet002 ucfnet002 - reference | eeb23d4 - 31 Mar 16
avatar joomla-cms-bot
joomla-cms-bot - comment - 31 Mar 2016

This PR has received new commits.

CC: @andrepereiradasilva


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9683.

avatar joomla-cms-bot
joomla-cms-bot - comment - 31 Mar 2016

This PR has received new commits.

CC: @andrepereiradasilva


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9683.

avatar andrepereiradasilva
andrepereiradasilva - comment - 31 Mar 2016

I'm a little confused about github

the first time is normal.

bottom line is, when you change any file in your patch-1 branch (the branch you originally used to create this pull request) in your joomla-cms fork repository they will automatically be in this PR.

this is your patch-1 branch https://github.com/ucfnet002/joomla-cms/tree/patch-1

avatar ucfnet002 ucfnet002 - reference | e4446c5 - 31 Mar 16
avatar joomla-cms-bot
joomla-cms-bot - comment - 31 Mar 2016

This PR has received new commits.

CC: @andrepereiradasilva


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9683.

avatar ucfnet002
ucfnet002 - comment - 31 Mar 2016

I deleted line 1329 and it seems to work ... here is my " administrator/templates/isis/css/template-rtl.css
": ucfnet002@e4446c5

avatar wojsmol
wojsmol - comment - 31 Mar 2016

@ucfnet002 run php build/generatecss.php from command line

avatar ucfnet002
ucfnet002 - comment - 31 Mar 2016

My dev environment isn't set up yet. i did the changes online in github. maybe someone can run this for me while i try to set up my local github repo. thx :-)

avatar joomla-cms-bot
joomla-cms-bot - comment - 31 Mar 2016

This PR has received new commits.

CC: @andrepereiradasilva


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9683.

avatar andrepereiradasilva andrepereiradasilva - test_item - 31 Mar 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 31 Mar 2016

I have tested this item :white_check_mark: successfully on 1c44b06


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9683.

avatar brianteeman brianteeman - test_item - 1 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 1 Apr 2016

I have tested this item :white_check_mark: successfully on 1c44b06


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9683.

avatar brianteeman brianteeman - change - 1 Apr 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 1 Apr 2016

RTC - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9683.

avatar joomla-cms-bot joomla-cms-bot - change - 1 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 1 Apr 2016
Milestone Added:
avatar JoomliC JoomliC - test_item - 3 Apr 2016 - Tested unsuccessfully
avatar JoomliC
JoomliC - comment - 3 Apr 2016

I have tested this item :red_circle: unsuccessfully on 1c44b06

Modal scrolling is broken on iphone and safari.
The reason i added overflow auto is due to a known issue with bootstrp 2 and 3. (Not fixed today) and because of a webkit issue.
The only known way to fix it is to force overflow.
I'm sorry, currently on holidays and with only my iphone, but i've alredy work on an improvement of my previous PR for 3.5.0
And could check it when back next week...
Sorry for timing...


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9683.

avatar brianteeman brianteeman - change - 3 Apr 2016
Status Ready to Commit Pending
Labels
avatar brianteeman
brianteeman - comment - 3 Apr 2016

Removed RTC status


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9683.

avatar joomla-cms-bot joomla-cms-bot - change - 3 Apr 2016
Labels Removed: ?
avatar brianteeman brianteeman - change - 4 Apr 2016
Title
Pull Request for Issue #9551 and #9586
Batch window issue
avatar brianteeman brianteeman - change - 4 Apr 2016
Title
Pull Request for Issue #9551 and #9586
Batch window issue
avatar infograf768
infograf768 - comment - 9 Apr 2016

Imho, this should be added to blockers as batch is badly broken since 3.5.0

avatar JoomliC
JoomliC - comment - 9 Apr 2016

@infograf768 i've worked on a redo of BS issue fix, and this one may solve batch issue too!
And the PR will be ready today (i'm testing again it, on different screen sizes and devices...)

Will inform about this PR in all issues related to the modals ;-)

avatar JoomliC
JoomliC - comment - 9 Apr 2016

@infograf768 @ucfnet002 @brianteeman @wojsmol @andrepereiradasilva a PR is ready to be tested as a redo of PR 9140 to fix scrolling of Bootstrap modals on small devices and iOS as well as fix for batch dropdown issue: #9817
;-)

avatar brianteeman
brianteeman - comment - 9 Apr 2016

Closing in favour of #9817 Please test

avatar brianteeman brianteeman - change - 9 Apr 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-04-09 19:58:16
Closed_By brianteeman
avatar brianteeman brianteeman - close - 9 Apr 2016
avatar brianteeman brianteeman - close - 9 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar zero-24
zero-24 - comment - 9 May 2016

@brianteeman @rdeutz please remove the milestone as it get never merged

avatar brianteeman brianteeman - change - 9 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment