User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Moved ".modal-body {" into mediaquery "@media (max-width: 767px)" in less-file of "isis"-template
in a menu, or content window select some items then click batch attempt to "move or copy" you will find the window is too small.
Apply this patch
repeat the test and on a standard screen it overflows correctly to allow you to select an item.
If possible test on multiple view ports particularly if you have a device has the max-width as above.
Not sure if it would be better removing it from the constraint totally.
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
sorry, didn't knew that. was my first submit to the joomla project.
brian, i saw your comment and so i decided to make this pull request. maybe it was a wrong way?
Category | ⇒ | Templates (admin) |
@aaleksanyants thank you - fixed
I have tested this item unsuccessfully on 92df354
Works fine on desktop and tablet but not on mobile XS viewport.
The comment held in the less file is as below, I was to busy to amend and test a correct solution.
Fix iOS scrolling inside bootstrap modals (using iframe) */
The testing of this PR would also need to take this into consideration. Was to busy to update the previous PR, and to investigate the reason for the original change.
Possible changes to the code will need to be :
/* ----------- iPhone 4 and 4S ----------- */
/* Portrait and Landscape */
@media only screen
and (min-device-width: 320px)
and (max-device-width: 480px)
and (-webkit-min-device-pixel-ratio: 2) {
}
/* Portrait */
@media only screen
and (min-device-width: 320px)
and (max-device-width: 480px)
and (-webkit-min-device-pixel-ratio: 2)
and (orientation: portrait) {
}
/* Landscape */
@media only screen
and (min-device-width: 320px)
and (max-device-width: 480px)
and (-webkit-min-device-pixel-ratio: 2)
and (orientation: landscape) {
}
/* ----------- iPhone 5 and 5S ----------- */
/* Portrait and Landscape */
@media only screen
and (min-device-width: 320px)
and (max-device-width: 568px)
and (-webkit-min-device-pixel-ratio: 2) {
}
/* Portrait */
@media only screen
and (min-device-width: 320px)
and (max-device-width: 568px)
and (-webkit-min-device-pixel-ratio: 2)
and (orientation: portrait) {
}
/* Landscape */
@media only screen
and (min-device-width: 320px)
and (max-device-width: 568px)
and (-webkit-min-device-pixel-ratio: 2)
and (orientation: landscape) {
}
/* ----------- iPhone 6 ----------- */
/* Portrait and Landscape */
@media only screen
and (min-device-width: 375px)
and (max-device-width: 667px)
and (-webkit-min-device-pixel-ratio: 2) {
}
/* Portrait */
@media only screen
and (min-device-width: 375px)
and (max-device-width: 667px)
and (-webkit-min-device-pixel-ratio: 2)
and (orientation: portrait) {
}
/* Landscape */
@media only screen
and (min-device-width: 375px)
and (max-device-width: 667px)
and (-webkit-min-device-pixel-ratio: 2)
and (orientation: landscape) {
}
/* ----------- iPhone 6+ ----------- */
/* Portrait and Landscape */
@media only screen
and (min-device-width: 414px)
and (max-device-width: 736px)
and (-webkit-min-device-pixel-ratio: 3) {
}
/* Portrait */
@media only screen
and (min-device-width: 414px)
and (max-device-width: 736px)
and (-webkit-min-device-pixel-ratio: 3)
and (orientation: portrait) {
}
/* Landscape */
@media only screen
and (min-device-width: 414px)
and (max-device-width: 736px)
and (-webkit-min-device-pixel-ratio: 3)
and (orientation: landscape) {
}
This PR has received new commits.
This PR has received new commits.
I'm a little confused about github
the first time is normal.
bottom line is, when you change any file in your patch-1
branch (the branch you originally used to create this pull request) in your joomla-cms
fork repository they will automatically be in this PR.
this is your patch-1
branch https://github.com/ucfnet002/joomla-cms/tree/patch-1
This PR has received new commits.
I deleted line 1329 and it seems to work ... here is my " administrator/templates/isis/css/template-rtl.css
": ucfnet002@e4446c5
@ucfnet002 run php build/generatecss.php
from command line
My dev environment isn't set up yet. i did the changes online in github. maybe someone can run this for me while i try to set up my local github repo. thx :-)
This PR has received new commits.
I have tested this item successfully on 1c44b06
I have tested this item successfully on 1c44b06
Status | Pending | ⇒ | Ready to Commit |
RTC - thanks
Labels |
Added:
?
|
Milestone |
Added: |
I have tested this item unsuccessfully on 1c44b06
Modal scrolling is broken on iphone and safari.
The reason i added overflow auto is due to a known issue with bootstrp 2 and 3. (Not fixed today) and because of a webkit issue.
The only known way to fix it is to force overflow.
I'm sorry, currently on holidays and with only my iphone, but i've alredy work on an improvement of my previous PR for 3.5.0
And could check it when back next week...
Sorry for timing...
Status | Ready to Commit | ⇒ | Pending |
Labels |
Removed RTC status
Labels |
Removed:
?
|
Title |
|
Title |
|
Imho, this should be added to blockers as batch is badly broken since 3.5.0
@infograf768 i've worked on a redo of BS issue fix, and this one may solve batch issue too!
And the PR will be ready today (i'm testing again it, on different screen sizes and devices...)
Will inform about this PR in all issues related to the modals ;-)
@infograf768 @ucfnet002 @brianteeman @wojsmol @andrepereiradasilva a PR is ready to be tested as a redo of PR 9140 to fix scrolling of Bootstrap modals on small devices and iOS as well as fix for batch dropdown issue: #9817
;-)
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-09 19:58:16 |
Closed_By | ⇒ | brianteeman |
Milestone |
Removed: |
Milestone |
Added: |
Milestone |
Added: |
Milestone |
Removed: |
@brianteeman @rdeutz please remove the milestone as it get never merged
Milestone |
Removed: |
Have not tested but this patch is incomplete as generate.css has not been ran.
If I run php build/generatecss.php today, I get: