? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
30 Mar 2016

Summary of Changes

PHPMailer has a configurable SMTPDebug property that allows logging of different types of messages from its internal API. Joomla doesn't change this from the default '0' (so no logging) under any condition. This PR adjusts JMail to set this property to the highest level when JDEBUG is true.

Testing Instructions

Apply the patch, enable debug mode, ensure the debug plugin is set to log everything (or at least messages in the 'mail' category), and do something that triggers a SMTP transaction. A more verbose set of messages should be found in the log in the 'mail' category detailing the transaction.

avatar mbabker mbabker - open - 30 Mar 2016
avatar mbabker mbabker - change - 30 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2016
Labels Added: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 30 Mar 2016

I have Debug set to yes in global config and the debug system plugin enabled and to log all.
i get a lot of logs in the logs dir but didn't got a mail log.
Do i have to anything else?

avatar mbabker
mbabker - comment - 30 Mar 2016

Shouldn't have to unless the config isn't being propagated into the SMTP class as it should. Anything calling $this->edebug() in the PHPMailer API (mainly the SMTP and PHPMailer classes) should get proxied to the callback function we're setting in JMail's constructor.

avatar andrepereiradasilva
andrepereiradasilva - comment - 30 Mar 2016

ok i see it's inside the everything.php log, sorry

avatar andrepereiradasilva andrepereiradasilva - test_item - 30 Mar 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 30 Mar 2016

I have tested this item :white_check_mark: successfully on dc8e150


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9678.

avatar andrepereiradasilva
andrepereiradasilva - comment - 30 Mar 2016

nice feature to simplify debugging SMTP connections!

avatar brianteeman brianteeman - test_item - 30 Mar 2016 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 30 Mar 2016

I have tested this item :red_circle: unsuccessfully on dc8e150

applied the patch
set the debug plugin to log everything
Set global config to use smtp
used the test email button
checked ALL logs and nothing about mail


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9678.

avatar mbabker
mbabker - comment - 30 Mar 2016

If you can do a var_dump of $this->Debugoutput and $this->SMTPDebug in PHPMailer::edebug() and $this->Debugoutput and $this->do_debug in SMTP::edebug() that'd help verify the right settings are being set/retained. My gut feeling is something could be overriding the debug handlers if you're not getting messages in the logs, but who knows.

avatar brianteeman
brianteeman - comment - 30 Mar 2016

Maybe my issue was testing using the send test button - will try again
tomorrow

On 30 March 2016 at 22:49, andrepereiradasilva notifications@github.com
wrote:

nice feature to simplify debugging SMTP connections!


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#9678 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar mikeveeckmans mikeveeckmans - test_item - 30 Mar 2016 - Tested successfully
avatar mikeveeckmans
mikeveeckmans - comment - 30 Mar 2016

I have tested this item :white_check_mark: successfully on dc8e150

Front end message on contact form : 2016-03-30T21:16:26+00:00 ERROR ::1 mail Error in JMail API: SMTP connect() failed. https://github.com/PHPMailer/PHPMailer/wiki/Troubleshooting

in everything.php log the SMTP errors and messages were found


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9678.

avatar brianteeman brianteeman - test_item - 31 Mar 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 31 Mar 2016

I have tested this item :white_check_mark: successfully on dc8e150

Changed my test to successful - my issue was related to a different bug


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9678.

avatar brianteeman brianteeman - change - 31 Mar 2016
Status Pending Ready to Commit
avatar andrepereiradasilva
andrepereiradasilva - comment - 31 Mar 2016

RTC (the label has already added in the tracker)

avatar joomla-cms-bot joomla-cms-bot - change - 31 Mar 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 9 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-09 14:34:37
Closed_By wilsonge
avatar wilsonge wilsonge - close - 9 Apr 2016
avatar wilsonge wilsonge - merge - 9 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 9 Apr 2016
avatar wilsonge wilsonge - reference | b14bbd0 - 9 Apr 16
avatar wilsonge wilsonge - merge - 9 Apr 2016
avatar wilsonge wilsonge - close - 9 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 9 Apr 2016
Labels Removed: ?
avatar wilsonge wilsonge - change - 9 Apr 2016
Milestone Added:
avatar mbabker mbabker - head_ref_deleted - 10 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment