[#9655] - Remove call to deleteUnexistingFiles()
- Fixed in Code Base
- 9 Apr 2016
- Medium
- Build: staging
- # 9655
- Diff
- mbabker:extra-delete-call
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Per comments on c864a01 this method call is no longer needed in the update step as it is triggered in the new finalisation file.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
If anyone tries to remove that function they deserve to be backhanded 42 times because it is used in the standalone update file, the database fix routine (what the flipping eff!?), AND in a CLI script, and if you can't figure out it's still used the reaction is 100% deserved.
I know thank you 
| Category | ⇒ | Installation |
I have tested this item 
successfully on 9e00f53
Tested with success as follows on a 3.5.0:
- Created one of the old files which should be deleted (on Linux: "touch" command). A list of files can be found here: 8c4bcba.
- Updated to a self made 3.5.1-rc2 patched by this PR using an self made custom URL: http://test5.richard-fath.de/list_test6.xml.
- Checked that the file created in step 1 has been deleted after the update.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9655.
In case if someone else wants to test in the same way as I did, I will leave my custom URL and the patched updated container behind it available for a few days or until this PR has RTC or is merged.
I have tested this item successfully on 9e00f53
It works. I have just tested the update Server from @richard67 thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9655.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
For 3.5.2 - this is a good optimisation but not something that requires us pushing back 3.5.1 again and releasing another new RC
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-09 14:34:08 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
rdeutz
- | Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
What do you think? Should we add a quick comment that this function is called by that script so that no one comes to the idea to remove that function? ;)