?
avatar brianteeman
brianteeman
29 Mar 2016

Steps to reproduce the issue

Select a parent menu item and its children and batch move to a new menu

Expected result

Parent and children successfully moved

Actual result

Parent and children moved BUT all to the same level

avatar brianteeman brianteeman - open - 29 Mar 2016
avatar brianteeman brianteeman - change - 29 Mar 2016
Status New Confirmed
avatar peteruoi
peteruoi - comment - 29 Mar 2016

and as a reminder a little relevant with batch actions #8600

avatar richard67
richard67 - comment - 29 Mar 2016

@brianteeman Your expected result is wrong from my point of view. If you select the new target for all of the menu items, you will move them all to the new target, so I would expect actual result.

The result which you expect, I would expect after selecting the parent only and moving this one. It should move the parent including all children with keeping the hierarchy.

Or am I wrong?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9651.

avatar brianteeman
brianteeman - comment - 29 Mar 2016

If I select an entire tree and move it then I expect it to stay as a tree.
Why would I not?

avatar richard67
richard67 - comment - 29 Mar 2016

Because you select same target for all. And when selecting the parent only and moving that, it copies the children with keeping the tree. So I would expect that to be desired behavior, but I agree with you that it confused me, too, when I first time noticed that.

avatar brianteeman
brianteeman - comment - 29 Mar 2016

Select all the items in a tree and MOVE to new menu - all the items are
not at the same level in the new menu
Select all the items in a tree and COPY to new menu - all the items are at
existing tree levels in the new menu

On 29 March 2016 at 18:50, Richard Fath notifications@github.com wrote:

Because you select same target for all. And when selecting the partent
only and moving that, it copies the children with keeping the tree. So I
would expect that to be desired behavior, but I agree with you that it
confused me, too, when I first time noticed that.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9651 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar richard67
richard67 - comment - 29 Mar 2016

Oh, this is in fact inconsistent, so you are right and there is an issue. Sorry for having had doubts.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 Mar 2016

Would expect same Behaviour on Move and Copy like its now at Move.

avatar alikon
alikon - comment - 29 Mar 2016

i'm unable to reproduce in "slow motion"

testing

avatar brianteeman
brianteeman - comment - 29 Mar 2016

Thanks for the video @alikon
In your case you selected the parent only and it moved the parent and children and kept the tree (and I can confirm this)
But in my case I had selected the parent AND the children and when I did the move they were all now as root level (no hierarchy) but when I did a copy the hierarchy was maintained


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9651.

avatar richard67
richard67 - comment - 29 Mar 2016

Question is: Which way should be the right one? It seems some prefer like it is now with copying, and some prefer like it is now with moving. Maybe it needs a kind of voting?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Mar 2016

Does one know Reason(s) for this Difference in Copy or Move? Btw: Modal-Window is too small in height.

avatar brianteeman
brianteeman - comment - 30 Mar 2016

I assume it is a bug

avatar alikon
alikon - comment - 30 Mar 2016

i'm not sure wich is the correct behviour for move & copy ,but,

in the case you select the parent and the children , and , we suppose that we are "moving a tree"
i think the children does not matter if it is selected or not cause the parent (tree) should be moved
where the selected children item is already in that tree
.... surely i'm supposing too much....

@franz-wohlkoenig yes, the batch modal window is quite unusable can you open an issue?

avatar brianteeman
brianteeman - comment - 30 Mar 2016

There already is a fix for the modal iirc

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Mar 2016

Started this Moment writing an Issue, stopped immediately; thanks @brianteeman

avatar simbus82
simbus82 - comment - 31 Mar 2016

For me is correct moving/copying the "tree" as is: it is very non-logic that if i select all voices from a tree then i see all voices moved/copied to the same level.

And there is no "clear" indication of how it works when we click the batch button... maybe is right to add a short guide in the modal window.

avatar brianteeman
brianteeman - comment - 31 Mar 2016

Is it correct that it works differently for move and copy?

On 31 March 2016 at 09:32, Simone Bussoni notifications@github.com wrote:

For me is correct moving/copying the "tree" as is: it is very non-logic
that if i select all voices from a tree then i see all voices moved/copied
to the same level.

And there is no "clear" indication of how it works when we click the batch
button... maybe is right to add a short guide in the modal window.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9651 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar simbus82
simbus82 - comment - 31 Mar 2016

@brianteeman in my honest opinion, no.
If i have a tree, i want that is the same after a move or after a copy to other menu.
Maybe, for who have to "disassemble" a menu tree, we can add a yes/no radio "keep the level tree".

avatar brianteeman
brianteeman - comment - 31 Mar 2016

Sorry I misread your original comment as if you were saying the current
behaviour was correct. I should have drunk more coffee

On 31 March 2016 at 09:42, Simone Bussoni notifications@github.com wrote:

@brianteeman https://github.com/brianteeman in my honest opinion, no.
If i have a tree, i want that is the same after a move or after a copy to
other menu.
Maybe, for who have to "disassemble" a menu tree, we can add a yes/no
radio "keep the level tree".


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9651 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar simbus82
simbus82 - comment - 31 Mar 2016

I'm saying that you are right :-) The actual batch is not working very well, copy do a thing, move do another thing... a little confusing!

avatar brianteeman
brianteeman - comment - 9 Dec 2016

So long and farewell

avatar brianteeman brianteeman - change - 9 Dec 2016
The description was changed
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2016-12-09 15:35:10
Closed_By brianteeman
avatar brianteeman brianteeman - close - 9 Dec 2016

Add a Comment

Login with GitHub to post a comment