nice. I will test when i have time.

I have tested this item successfully on 3bdfa51

Tested both updating a 3.4.8 and a 3.5.0 with give custom URL.

Cache in both cases on, conservative caching with cache handler = file, page cache plugin = enabled with used browser cache = yes, cache was filled before update.

After update, cache was cleared in both cases.

I am not sure if this will solve all issues related to caching after update, because some of the issues may come from browsers still having js files cached.

But this is not related to this PR here.

Ah I just see Andre had the same thoughts about cached js.

Yes there is a feature that is called MD5CHECKSUM File. But This should be another PR. ;)

@zero-24 Maybe you should give your PR the "Easy test" flag? Could help to find more testers, and is really easy to test.

@zero-24 is this suppose to clean Site (frontend) and Administrator (Backend) cache?

Is the test i made it's not clearing all cache.

BTW, is there any way to clean all js/css admin template in browser cache too?

Joomla! already use $doc->addStyleSheetVersion() in default template.

@andrepereiradasilva Some of the admin cache remained also in my test, like fof cache, but I think this is normal, it also happens when you manually clear the cache. Frontend cache was completely cleared.

@andrepereiradasilva Some of the admin cache remained also in my test, like fof cache, but I think this is normal, it also happens when you manually clear the cache. Page cache was completely cleared.

Mine the admin has cleared (some where recreated on load so they appeared on admin cache), but the site wasn't cleared. That's why i asked.

Few thoughts since this has been hijacked, and I'm just going to end up repeating everything I've said before here (sorry if you've heard it before):

• Not everything requires a query string version, don't mandate that everything has to have it (don't think that's ever been suggested but getting ahead of the curve here)
• If media loaded through $doc->add***Version() isn't correctly getting version strings changed post update, there's a bug in that process somewhere that needs to be addressed
• JHtml already has a version string mechanism with MD5SUM files in directories, don't proxy it to the doc's version methods unless you intend on deprecating the MD5SUM functionality (this is also the only way right now to do version strings with JHtml loaded assets unless you're hijacking the JDocument head and manipulating it before it's rendered)
• Asset files like this aren't loaded through Joomla at all, so unless there's a global "tell browser to bust cache for everything on this domain" header, not sure what can be done at that level (especially since I'm fairly sure things like last modified time are sent with the response headers and browsers should be smart enough to bust cache if it detects that changed)

ok, now regarding this PR, as said before, in my test the joomla frontend cache was not cleared.

This PR has received new commits.

CC: @richard67

@andrepereiradasilva hmm can you please double check? For me it works.

This is how it looks bevor the update:

and this after the update:

maybe you use the wrong update package?

I have tested this item successfully on 9b20904

I have tested this item successfully on 9b20904

sorry it must be something on my side.

It works.

Ryc

Rtc

hm, thought ... how it affect 3d extensions that has a large amount of data in the cache, on heavily loaded site?

i think @Fedik has a good point here.

this change can crash them all,
maybe better would be specify which cache group(s) need to clean up?

probably, and correct if i'm wrong, the most important for the update process in clean the administrator cache.