[#9619] - Sessionfix
- Fixed in Code Base
- 27 Mar 2016
- Medium
- Build: staging
- # 9619
- Diff
- wilsonge:sessionfix
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #8851 .
Summary of Changes
This fixes two things:
- The double login that occurs when your session expires
- When restarting a session the id wasn't being regenerated properly as the session hadn't been started yet. This was causing PHP Warnings in PHP 7 (ref: #9555 //cc @andrepereiradasilva)
Testing Instructions
- Let your session expire (it might help lowering the session time to 1-2 minutes in global configuration)
- Try and login
- Login a second time
- Apply patch
- Let session expire again
- Login first time around successfully.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Title |
|
||||||
| Milestone |
Added: |
||
| Title |
|
||||||
| Milestone |
Added: |
||
| Category | ⇒ | Libraries |
Tested with success on PHP 5.6. Now will test on PHP 7 to see if there are any warnings.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9619.
I have tested this item 
successfully on d08fd12
I tested with both PHP 5.6 and 7.
The thing with warnings in PHP 7 I could not reproduce. Did not have any warning without and with this PR.
Maybe the reason is that I have session handler = database and not PHP?
Anyway: This PR works as smooth as a fresh creamed baby butt.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9619.
I don't have a PHP 7 set up at the moment as just got a new laptop. But I think that @andrepereiradasilva could only get it when running the sample command line script I had in #9555
Anyway, your sessionfix does the session fix 
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
I have tested this item successfully on d08fd12
Good morning... A bit late but success on PHP 5.6 & 7 - Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9619.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-27 13:47:51 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
@wilsonge just tested. this also solves the warnings on php 7 i had on CLI scripts too (#9555 (comment)).
Woot :D
I have tested this item
successfully on d08fd12
Tested with php 5.6 and 7
great stuff!!!!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9619.