User tests: Successful: Unsuccessful:
See #9592
When editing a template file, whether with Codemirror or editor None, the files are saved with Windows EOL (CRLF) instead of Unix (LF).
To test, go to administrator=>Templates=>Beez=>Edit template
/administrator/index.php?option=com_templates&view=template&id=503
Edit a php file, for example: component.php
Save and close.
Now Manually open the file on the desktop with a TextEditor (I use BBEdit on Macintosh).
The file has now Windows EOL (CRLF) instead of Unix ending.
Apply this patch and test again: we now have Unix line endings.
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Easy | No | ⇒ | Yes |
Category | ⇒ | Administration Components |
As I asked before - why does this matter?
Title |
|
Why do you think we use all over Joomla Unix EOL? This PR is done to normalize EOL.
@infograf768 Here is working fine now.
I don't understand why this is no matter @brianteeman.
My gedit editor is able to open and save files in several formats, so, my editor is cool due i can work in several formats, but, if my editor is opening files with a format and save the same file, hiddenly, with another distinct, i will think that my editor is bugged.
If the editor was not the cause, ok, but for me that one is a bug.
I am just trying to understand what the issue is
On 27 March 2016 at 11:10, Rafael Gómez notifications@github.com wrote:
@infograf768 https://github.com/infograf768 Here is working fine now.
I don't understand why this is no matter @brianteeman
https://github.com/brianteeman.My gedit editor is able to open and save files in several formats, so, my
editor is cool due i can work in several formats, but, if my editor is
opening files with a format and save the same file, hiddenly, with another
distinct, i will think that my editor is bugged.If the editor was not the cause, so, ok, but for me that one is a bug.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9616 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
@brianteeman It looks like a matter of not following the Coding Standards when editing the template files. Correcting it to Unix LF make it meet the Standards https://joomla.github.io/coding-standards/?coding-standards/chapters/basic-guidelines.md
Thank you @ot2sen thats the perfect answer to my question
On 27 March 2016 at 11:47, ot2sen notifications@github.com wrote:
@brianteeman https://github.com/brianteeman It looks like a matter of
not following the Coding Standards when editing the template files.
Correcting it to Unix LF make it meet the Standards
https://joomla.github.io/coding-standards/?coding-standards/chapters/basic-guidelines.md—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9616 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
If the issue is not coming from the editor allowing mix EOLs, can to be the cause of this issue that Joomla is mixing file formats?
I mean that not all files in Joomla are:
File Format
All files contributed to Joomla must be:
Stored as ASCII text Use UTF-8 character encoding Be Unix formatted following these rules. Lines must end only with a line feed (LF). Line feeds are represented as ordinal 10, octal 012 and hex 0A. Do not use carriage returns (CR) like Macintosh computers do or the carriage return/line feed combination (CRLF) like Windows computers do.
I have tested this item successfully on b6cc1ae
This PR has received new commits.
CC: @richard67
Thanks @bembelimen . Indeed no need. Corrected.
Please test and mark it in https://issues.joomla.org/tracker/joomla-cms/9616
I have tested this item successfully on 2905fa6
I have tested this item successfully on 2905fa6
Status | Pending | ⇒ | Ready to Commit |
RTC, Thanks for testing.
This can go in 3.5.1
Labels |
Added:
?
|
Milestone |
Added: |
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-28 17:14:07 |
Closed_By | ⇒ | wilsonge |
Labels |
Removed:
?
|
@Valc @okonomiyaki3000 @brianteeman
Thank you for testing