? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
27 Mar 2016

See #9592
When editing a template file, whether with Codemirror or editor None, the files are saved with Windows EOL (CRLF) instead of Unix (LF).

To test, go to administrator=>Templates=>Beez=>Edit template
/administrator/index.php?option=com_templates&view=template&id=503

Edit a php file, for example: component.php
Save and close.

Now Manually open the file on the desktop with a TextEditor (I use BBEdit on Macintosh).

The file has now Windows EOL (CRLF) instead of Unix ending.

Apply this patch and test again: we now have Unix line endings.

avatar infograf768 infograf768 - open - 27 Mar 2016
avatar infograf768 infograf768 - change - 27 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Mar 2016
Labels Added: ?
avatar infograf768 infograf768 - change - 27 Mar 2016
Easy No Yes
avatar infograf768 infograf768 - change - 27 Mar 2016
Category Administration Components
avatar infograf768
infograf768 - comment - 27 Mar 2016

@Valc @okonomiyaki3000 @brianteeman
Thank you for testing

avatar brianteeman
brianteeman - comment - 27 Mar 2016

As I asked before - why does this matter?

avatar brianteeman brianteeman - change - 27 Mar 2016
Title
Correction: Saving template files with Unix End of Line (EOL) (solves #9652)
Correction: Saving template files with Unix End of Line (EOL) (solves #9592)
avatar infograf768
infograf768 - comment - 27 Mar 2016

Why do you think we use all over Joomla Unix EOL? This PR is done to normalize EOL.

avatar Valc
Valc - comment - 27 Mar 2016

@infograf768 Here is working fine now.

I don't understand why this is no matter @brianteeman.

My gedit editor is able to open and save files in several formats, so, my editor is cool due i can work in several formats, but, if my editor is opening files with a format and save the same file, hiddenly, with another distinct, i will think that my editor is bugged.

If the editor was not the cause, ok, but for me that one is a bug.

avatar brianteeman
brianteeman - comment - 27 Mar 2016

I am just trying to understand what the issue is

On 27 March 2016 at 11:10, Rafael Gómez notifications@github.com wrote:

@infograf768 https://github.com/infograf768 Here is working fine now.

I don't understand why this is no matter @brianteeman
https://github.com/brianteeman.

My gedit editor is able to open and save files in several formats, so, my
editor is cool due i can work in several formats, but, if my editor is
opening files with a format and save the same file, hiddenly, with another
distinct, i will think that my editor is bugged.

If the editor was not the cause, so, ok, but for me that one is a bug.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9616 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar ot2sen
ot2sen - comment - 27 Mar 2016

@brianteeman It looks like a matter of not following the Coding Standards when editing the template files. Correcting it to Unix LF make it meet the Standards https://joomla.github.io/coding-standards/?coding-standards/chapters/basic-guidelines.md

avatar brianteeman
brianteeman - comment - 27 Mar 2016

Thank you @ot2sen thats the perfect answer to my question

On 27 March 2016 at 11:47, ot2sen notifications@github.com wrote:

@brianteeman https://github.com/brianteeman It looks like a matter of
not following the Coding Standards when editing the template files.
Correcting it to Unix LF make it meet the Standards
https://joomla.github.io/coding-standards/?coding-standards/chapters/basic-guidelines.md


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9616 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar Valc
Valc - comment - 27 Mar 2016

If the issue is not coming from the editor allowing mix EOLs, can to be the cause of this issue that Joomla is mixing file formats?
I mean that not all files in Joomla are:

File Format

All files contributed to Joomla must be:

Stored as ASCII text
Use UTF-8 character encoding
Be Unix formatted following these rules.
    Lines must end only with a line feed (LF).
    Line feeds are represented as ordinal 10, octal 012 and hex 0A.
    Do not use carriage returns (CR) like Macintosh computers do or the carriage return/line feed combination (CRLF) like Windows computers do.
avatar richard67 richard67 - test_item - 27 Mar 2016 - Tested successfully
avatar richard67
richard67 - comment - 27 Mar 2016

I have tested this item :white_check_mark: successfully on b6cc1ae


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9616.

avatar joomla-cms-bot
joomla-cms-bot - comment - 27 Mar 2016

This PR has received new commits.

CC: @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9616.

avatar infograf768
infograf768 - comment - 27 Mar 2016

Thanks @bembelimen . Indeed no need. Corrected.

avatar infograf768
infograf768 - comment - 27 Mar 2016
avatar richard67 richard67 - test_item - 27 Mar 2016 - Tested successfully
avatar richard67
richard67 - comment - 27 Mar 2016

I have tested this item :white_check_mark: successfully on 2905fa6


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9616.

avatar bembelimen bembelimen - test_item - 27 Mar 2016 - Tested successfully
avatar bembelimen
bembelimen - comment - 27 Mar 2016

I have tested this item :white_check_mark: successfully on 2905fa6


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9616.

avatar infograf768 infograf768 - change - 27 Mar 2016
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 27 Mar 2016

RTC, Thanks for testing.

@wilsonge

This can go in 3.5.1


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9616.

avatar joomla-cms-bot joomla-cms-bot - change - 27 Mar 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 27 Mar 2016
Milestone Added:
avatar wilsonge wilsonge - change - 28 Mar 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-03-28 17:14:07
Closed_By wilsonge
avatar wilsonge wilsonge - close - 28 Mar 2016
avatar wilsonge wilsonge - merge - 28 Mar 2016
avatar joomla-cms-bot joomla-cms-bot - close - 28 Mar 2016
avatar joomla-cms-bot joomla-cms-bot - change - 28 Mar 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment