following second test at step : apply this pr
got from com_patchtester
Error
The file marked for modification does not exist: build.xml

@aliko that is because i have add the media folder to this pr but it don't exist in stable. Can you test my zip file? I'm going to report it to com_patchtester :)

after install your com_joomlaupdate.zip -> in Components ->Joomla! Update
Parse error: syntax error, unexpected '<' in C:\xampp\htdocs\pr\administrator\components\com_joomlaupdate\views\default\tmpl\default_nodownload.php on line 20

just add ?> to the end of line 20

Yes @alikon i have fixed the repo and my local instance but not the container :(

Now i have done it see the zip above.

First test
Everything worked as described but I never saw a files extracted (this might be unrelated to this PR)

Test two - same issue as @alikon with the build.xml so manually installed the component from https://github.com/joomla/joomla-cms/files/190845/com_joomlaupdate.zip

I dont see any "reinstall" option

I do see a Warning section which isnt very helpful

I just tested and have same results as Brian for test 2, i.e. not see the reinstall option, also not after toggling the update channel or using the clear cache button.

Joomla! caching is off btw.

In addition I tested FTP installation method for the Upload & Install, and this is broken (as it was with Nik's PR, too).

I entered correct server and port and credentials in the ftp fields, same info as I have saved in global config.

What is strange: It is also broken for the Live Update, not only for Upload & Install, but it was definitely working in past, and since the Live Update is the old functionality I would not expect any change there.

Could my problems with FTP mode be related to the fact that I password-protected my test domain?

But this was not a problem before in 3.4.8 or 3.5.0. or ever in past, so I do not really think so.

@brianteeman @alikon for com_patchtester you need to apply: joomla-extensions/patchtester#133

I can have a look into the other things later today.

@zero-24 If I find time I will try to find out what goes wrong with the FTP method. If I find out something I'll let you know. I wish you a good Easter fest.

@zero-24 I added some error_log call before the calls of function "@ftp_connect" in restore.php and could see that "$this->host" and "$this->port" are empty strings when "@ftp_connect" is called in function "connect()" of class AKPostprocFTP.

@zero-24 When comparing code of original update component and yours, I cannot find an explanation for the problems with the ftp mode. Can it be that the ftp mode also failed all the time with the original update component, and it fell back to file copy mode so nobody ever noticed, and your PR just makes this visible now but not caused the error?

@zero-24 You can find my fix for making FTP mode work here: zero-24#2.

Can you check and if ok merge?

And if you understand why this 1 line which I removed made it not work, could you let me know?

I do not really understand that, I only saw it was not there in the original 3.5.0 update component, and so I removed it from your component and tested FTP mode, and it worked.

@nikosdion Do you know why FTP mode works only after removing the one line as I proposed with zero-24#2 ?

@richard67 It doesn't fix anything. It introduces a bug, causing Joomla! Update to always use direct file writes no matter what you select.

@nikosdion I see, you are right. Sorry for disturbing. Have to see if I can find out what goes wrong.

I do see a Warning section which isnt very helpful

Should be fixed with my last commit for the bug that @andrepereiradasilva found 36b1849

@alikon @brianteeman

I have just checked the issue that you can't see the reinstall.

There we have two issues.

• With the package you installaed i can not update the lib file but that you need for reinstall
• And there is a problem with the "Test" Update Server (see: joomla/update.joomla.org#7). If you use the standard Update server all works great.

Workarrounds for the reinstall

So we have two workarrounds.
First manually patch the lib file here (just replace with the new one): libraries/joomla/updater/updater.php
https://raw.githubusercontent.com/zero-24/joomla-cms/feature/joomlaupdate-reinstall/libraries/joomla/updater/updater.php

Seccond work arround is apply this patch using com_patchtester and this fix for com_patchtester: joomla-extensions/patchtester#133

Limitations of the com_joomlaupdate standalone release

The only limitation should be that the reinstall not work as this requires the new lib file that can't (ok should not) be shipped with the standalone release.

I have just updated the standalone package and fixed the testinstructions for reinstall if you come with the standalone package and not with the fixed com_patchtester

@richard67 As for FTP i cannot help here. I have no setup that require ftp updates.

@alikon did you test with postgres? So we are sure that the SQL error is gone / fixed with this version of that branch as it should ;)

@zero-24 If you do not have a setup that requires ftp updates, you maybe have one which would allow them? It just needs an ftp server with old insecure passive ftp on your test system.

It seems FTP access information (hostname and so on) are not passed over, the variables are empty when calling ftp_connect.

It could be that this also does not work on staging or 3.5.0 or even 3.4.8 but nobody ever noticed because direct write is used silently in background. At leats it seemed like this when I tried my (wrong) PR for you before.

I have to check if adding some error_log call before the calls of function "@ftp_connect" in restore.php will show that "$this->host" and "$this->port" are empty strings when "@ftp_connect" is called in function "connect()" of class AKPostprocFTP also on a staging or a clean 3.5.0 (or even a 3.4.8), then we know for sure it is not related to this PR.

Beside this, everything worked in direct write mode here.

@mbabker can you check here: ea5f249 that i have not broken the ant script and the language files get copied to the right places?

I still dont see any reinstall option. Maybe I am looking in the wrong place - can you post a screenshot of what I should see

@brianteeman

• What workarround did you try? The new com_patchtester release or replaced the lib file manually?
• What Update server do you use?

The reinstall feature looks like this

I had to press the clear cache button on that page
Before that it just didnt show

On 27 March 2016 at 22:20, zero-24 notifications@github.com wrote:

@brianteeman https://github.com/brianteeman

• What workarround did you try? The new com_patchtester release or replaced the lib file manually?
• What Update server do you use?

The reinstall feature looks like this
[image: reinstall_feature]
https://cloud.githubusercontent.com/assets/2596554/14067922/620bf1c0-f472-11e5-8aed-fc7861d3819d.JPG

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9612 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Unable to install patch tester in 3.4.8 to run the test

@Webdongle Testing instructions do not say anything about installing the patchtester on the 3.4.8.
Beside this, the latest patch tester RC (and also Beta 5 before) require Joomla! 3.5.

@Webdongle

Patchtester requires 3.5 but you can test the first case without patchtester on the 3.5.0 (seccond test) you can install patchtester ;)

@brianteeman

I had to press the clear cache button on that page
Before that it just didnt show

Ok so it works now for you?

@zero-24 @richard67

Test says install 3.4.8 ...

I use patch tester to pull the pr

yes all good except for my comment earlier about the files extracted

will try and test on pgsql before i go on holiday

On 27 March 2016 at 22:27, zero-24 notifications@github.com wrote:

@Webdongle https://github.com/Webdongle

Patchtester requires 3.5 but you can test the first case without
patchtester on the 3.5.0 you can install patchtester ;)

@brianteeman https://github.com/brianteeman

I had to press the clear cache button on that page
Before that it just didnt show

Ok so it works now for you?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9612 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Great thanks @brianteeman !

@Webdongle

Test says install 3.4.8 ...

Yes but the first test says nothing about com_patchtester ;)

There you need to run the update SQL (to use my update server) and install the update for com_joomlaupdate than you can use the new layout and update to 3.5.0. :)

In the seccond test you start with a 3.5.0 and you can install com_patchtester :)

If you really need the patch tester, you can go back a couple of beta releases. The beta 4 tag was the last one to support Joomla 3.3 and up.

com_patchtester
Error this error facing.i am cpompletely unstable,i need to work dione.http://blogspotforbloggertipsandtricks.blogspot.com

It's OK ... was too keen to test and never read the instructions carefully

install 3.5.0 stable or staging (you can also use the result of the first test)
install com_patchtester
apply this fix of com_patchtester: joomla-extensions/patchtester#133

#133 is there any need now it has been merged into patch tester ?

I have tested this item successfully on fd8e576

Everything works in direct write mode.

Problems with FTP mode are not related to this PR. I opened a separate issue for that.

What is not nice but I can live with it:

If you just have updated and so the installed version is the latest available, it needs again a click on the "Clear cache" button to make the "reinstall" option visible.

But I can live with that and so see my test as successful.

@richard67 Thanks for testing

If you just have updated and so the installed version is the latest available, it needs again a click on the "Clear cache" button to make the "reinstall" option visible.

Just to explain the problem this only happens the first time as we change the updater.php file that adds some extra info to the update object. That extra info is not there bevor we update and the new code (and the new updater.php) runs only if we check again for updates or clear the update cache so this is expected

I have tested this item successfully on fd8e576

OK ... read the instructions thoroughly now

Test 1 Full Success

Test 2 reinstall and Upload&Update Full Success

This is a fantastic well needed feature.

@zero-24 Well, yes, I simply did not have in mind that the updates to which I updated in the test did not contain your PR, so after update it had to be applied again and then needed also the clear cache button. With a Joomla! update container patched with this PR, the test would have been like in real life.

tested with postgres - ok

@zero-24 with current staging second test with

• this updater https://raw.githubusercontent.com/zero-24/joomla-cms/feature/joomlaupdate-reinstall/libraries/joomla/updater/updater.php

• Patch Tester 2.0.0 Release Candidate

still unable to see the reinstall button

what i'm doing wrong?

You need to change the version.php so that you get JVERSION = 3.5.0 else the updater can't find a update or the files as 3.5.1-dev is not uploaded to the update server ;)

That happened to me just now on a new test after it had worked before -odd

@brianteeman which joomla version you use / have in the version.php the only version that can find the update package is 3.5.0

And if you use the Tst Update server there is a problem with that server (i have created a PR against that repo to fix it)

chenged version.php file like 3.5.0 stable but still no reinstall button....
i'm on default channel

@alikon Because I see your screenshots shows you are on 3.5.1-dev: For testing with this 3.5.1-dev version you can use following custom url: http://test5.richard-fath.de/list_test1.xml, which I made for one of my PRs.

If offers also a 3.5.1-dev version, and with this I could see the "reinstall" thing because offered version = installed version.

@brianteeman If you also are aleady on 3.5.1.-dev, this is of course also possible for you.

No need to really install from my custom ULR then, but if you wanna help with testing my PR (just look for open PRs from me, there are 2, the younger one is the one where this custom URL is used) would be nice.

@alikon Ah I see now you are on 3.5.0. Then my previous post will not help.

@richard67 i've tried with a custom url but maybe mine was wrong... let's try yours i just want to see
the "Super-Usefull" reinstall button

try this one as custom URL

https://raw.githubusercontent.com/andrepereiradasilva/update.joomla.org/master/www/core/teststs/list_sts.xml

And clear the cache

Additional info

In this case, the list_sts.xml xml is

<extensionset name="Joomla Core" description="Joomla! Core">
    <extension name="Joomla" element="joomla" type="file" version="3.5.1-dev" targetplatformversion="3.5" detailsurl="https://raw.githubusercontent.com/andrepereiradasilva/update.joomla.org/master/www/core/teststs/extension_sts.xml"/>
</extensionset>

The extension_sts.xml xml is

<?xml version="1.0" ?>
<updates>
    <update>
        <name>Joomla! 3.5.1</name>
        <description>Joomla! 3.5.1 CMS</description>
        <element>joomla</element>
        <type>file</type>
        <version>3.5.1-dev</version>
        <infourl title="Joomla!">https://www.joomla.org/announcements/release-news/5654-joomla-3-5-is-here.html</infourl>
        <downloads>
            <downloadurl type="full" format="zip">https://github.com/joomla/joomla-cms/releases/download/3.5.0/Joomla_3.5.0-Stable-Update_Package.zip</downloadurl>
        </downloads>
        <tags>
            <tag>stable</tag>
        </tags>
        <maintainer>Joomla! PLT</maintainer>
        <maintainerurl>https://www.joomla.org</maintainerurl>
        <section>STS</section>
        <targetplatform name="joomla" version="3.[345]" />
        <php_minimum>3.10.0</php_minimum>
    </update>
</updates>

Same as mine regarding XMLs (exccept the zip behind it).

i think for 3.5.0 is just replace the 3.5.1-dev parts by 3.5.0 in the two xmls.

yep. Often the 1st one is forgotten to change. "targetplatform" is also important, has to be as shown in your xml above, i.e. inlcude the 5 in the subversion pattern.

mine custom url .xml file was wrong with yours finally reinstall button appears

RTC

@brianteeman Why can't it go into 3.5.1?

That decision is nothing at all to do with me. It is up to the maintainer
(@wilsonge)

I am guessing because it has new language strings.

Ah, OK. Just wanted to ask, not wanted to blame anyone.

Makes sense with the language strings, but on the other hand we had so many issues with people trying to use extension installer hat I thought it would be better to have it in 3.5.1 even if not translated yet. But I might be wrong of course.

I agree with you but it's not my call

The last plan by @wilsonge i know is a standalone release of com_joomlaupdate this way this improvents (expected the reinstall feature) can be installed also in 3.4.8 for updating ;)

For that reason i have moved the since tags to 3.5.2 too :)

The last plan by @wilsonge i know is a standalone release of com_joomlaupdate this way this improvents (expected the reinstall feature) can be installed also in 3.4.8 for updating ;)

But what would happen for new lang strings? TTs need these to be in core en-GB

If George does not use at least 1 of my changes in my PR for solving problems on updating related to the utf8mb4 conversion, he will have to release a 3.5.2 anyway soon after 3.5.1, but that's another story.

The Update component was originally provided free by Nick from his Extension. If the Update component is now to be a 'Stand alone' has Nick been consulted ?

The update component was made standalone since Joomla 3.5.0 - me and nic have been in extensive discussions about how to roll this out since the decision was made (and this pull request he made was made at my request) so yes he has been consulted

Actually since the mess of 3.3.4->3.3.6 Joomla Update has been able to be updated standalone - we have just not needed to do it yet. And yes it comes at the price of TT's not being able to translate the strings in < 3.5.2 so it's not a decision that I'm taking lightly either - but it's there for people who want it and those who have already upgraded to the latest stable version of Joomla have it available as well

@wilsonge
If joomlaupdate is now standalone and new strings will not be in core en-GB until 3.5.2, we still can propose TTs who can do to include the new strings into their 3.5.1 packs to come. Those using crowdin will not be able for sure, but others can.

Are the strings proposed here in this PR sure to be added? If yes, just let me know and I will let it know to TTs.

Would it not make more sense to have it as part of the Update component for 3.5.0 onwards and a separate standalone for older versions ?
If it's a stand alone only then it will (in essence to the ordinary user ) be no different than any other 3rd party extension. But if it is part of the core then it will be a feature. @wilsonge please reconsider.

me and nic have been in extensive discussions about how to roll this out since the decision was made

And he is no longer adding code to it. I hope he doesn't see a stand alone version as 'competition' to his extensions. [at the risk of being banned for expressing an opinion] imho it is Nick who should decide if it it is to be a stand alone instead of part of Joomla core.

My understanding is that it IS part of the core but by technically making
it standalone AND offering it on its own it can
a) be installed on earlier releases
b) upgraded outside of the joomla core update process (this is really
important)

On 29 March 2016 at 12:05, Kevin Griffiths notifications@github.com wrote:

Would it not make more sense to have it as part of the Update component
for 3.5.0 onwards and a separate standalone for older versions ?
If it's a stand alone only then it will (in essence to the ordinary user )
be no different than any other 3rd party extension. But if it is part of
the core then it will be a feature. @wilsonge
https://github.com/wilsonge please reconsider.

me and nic have been in extensive discussions about how to roll this out
since the decision was made
And he is no longer adding code to it. I hope he doesn't see a stand alone
version as 'competition' to his extensions. [at the risk of being banned
for expressing an opinion] imho it is Nick who should decide if it it is to
be a stand alone instead of part of Joomla core.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9612 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Hi @brianteeman

My understanding is that it IS part of the core

I couldn't find it. I clicked clear cache but the Joomla update component didn't offer to reinstall. Nor was there a second tab to upload/install. The update component in 3.5.1RC looks exactly like in 3.5.0 not like it did after I tested this patch.

We are not going to be offering this on JED as "competition" to nic's stuff. It's just there so people who need file uploads and for some reason are still running on 3.4.8 can use file upload without having to run through the tedious file extraction method....

@wilsonge

Where is the stand alone update component ? can I have a link please ?

The "standalone" component is exactly what we ship in the CMS right now - you can generate the standalone package by running this script https://github.com/joomla/joomla-cms/blob/staging/build.xml#L142 - I haven't had time to do it myself yet so i can't link you to a package

Whoever said it wont be merged. This is RTC with a milestone of 3.5.2

This as is is going to be merged. All we are going to do is also produce a zip of exactly this that people can upload onto older Joomla sites (especially people still stuck on 3.4.8)

Thanks @brianteeman @wilsonge

I obviously misunderstood.... I thought the stand alone zip was instead of having it in the core.

No it will be in core but by making it something that can be installed it
can be installed in earlier releases of joomla but more importantly it
allows for the situation where we need to change the updater BEFORE someone
can update their joomla release.

On 7 April 2016 at 22:11, Kevin Griffiths notifications@github.com wrote:

Thanks @brianteeman https://github.com/brianteeman @wilsonge
https://github.com/wilsonge

I obviously misunderstood.... I thought the stand alone zip was instead of
having it in the core.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9612 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

For reference we made it possible to do this after 3.3.6 needed to be released because of an issue introduced into the restore.php script. The mechanism has never been needed though.

@zero-24 could you have a look at the merge conflicts, danke

This PR has received new commits.

CC: @richard67, @Webdongle

Fixed @rdeutz but please double check with @wilsonge about this PR.

I will be able to test again tomorrow if still necessary then.

This PR has received new commits.

CC: @richard67, @Webdongle

Sorry guys i have just fixed it by merging brian's PR thanks @andrepereiradasilva & @brianteeman