Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#9596] - Add another check to the renderfield layout of com_contact to determine whether or not a field is required

? Success
Pull Request for # 9552

User tests: Successful: Unsuccessful:

avatar matrikular
matrikular
25 Mar 2016

Summary of Changes

This PR fixes issue #9552 reported by RoscioZ

In #8473 I introduced a component specific renderfield override so that layouts can be "free" of static form / field rendering code blocks. As mentioned in the description and discussion, the implementation is not very clean. Parsing HTML is seldom a good idea.

Testing Instructions

To check that the reported problem has been fixed:

  1. Create a contact item in the backend
  2. Create a menu item for that contact
  3. Enable the "Captcha - ReCaptcha" plugin and select that plugin in the site tab of the global configuration
    Note: You may have to generate a key to be able to use / see the captcha on your webseite. Any key that is valid for a website is also valid on localhost.
  4. Open the contact page in the frontend. As reported, the captcha field shows the (optional) suffix, which should not be there
  5. Apply the patch - the suffix should be gone
avatar matrikular matrikular - open - 25 Mar 2016
avatar matrikular matrikular - change - 25 Mar 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Mar 2016
Labels Added: ?
avatar yvesh
yvesh - comment - 25 Mar 2016

@Test working fine. Thanks :)

avatar brianteeman brianteeman - alter_testresult - 25 Mar 2016 - yvesh: Tested successfully
avatar brianteeman brianteeman - change - 25 Mar 2016
Rel_Number 0 ⇒ 9552
Relation Type ⇒ Pull Request for
avatar brianteeman brianteeman - change - 25 Mar 2016
Category ⇒ Layout
avatar RoscioZ RoscioZ - test_item - 25 Mar 2016 - Tested successfully
avatar RoscioZ
RoscioZ - comment - 25 Mar 2016

I have tested this item :white_check_mark: successfully on 5038b5f

tested! works thanks

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9596.

avatar bembelimen bembelimen - test_item - 25 Mar 2016 - Tested successfully
avatar bembelimen
bembelimen - comment - 25 Mar 2016

I have tested this item :white_check_mark: successfully on 5038b5f

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9596.

avatar brianteeman brianteeman - change - 25 Mar 2016
Status Pending ⇒ Ready to Commit
avatar brianteeman
brianteeman - comment - 25 Mar 2016

RTC thanks

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9596.

avatar joomla-cms-bot joomla-cms-bot - change - 25 Mar 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 25 Mar 2016
Milestone Added:
avatar wilsonge wilsonge - change - 25 Mar 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-03-25 22:18:01
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 25 Mar 2016
avatar wilsonge wilsonge - merge - 25 Mar 2016
avatar joomla-cms-bot joomla-cms-bot - close - 25 Mar 2016
avatar wilsonge wilsonge - reference | d1ab1e1 - 25 Mar 16
avatar wilsonge wilsonge - merge - 25 Mar 2016
avatar wilsonge wilsonge - close - 25 Mar 2016
avatar joomla-cms-bot joomla-cms-bot - change - 25 Mar 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment