[#959] - Detect Chrome for iOS in browser.php
- Closed
- 30 Apr 2013
- Medium
- Build: 2.5.x
- # 959
- Diff
- wilsonge:chromeios
- Foreign ID 29922
User tests: Successful: Unsuccessful:
Fixes #29922
See here: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=29922
This PR fixes 3.x: #956
I believe there is a typo here: it should read:
$this->_agent
instead of $this->agent as it is currently. I get a warning on my machine when I run with this update.
P.S. @nicksavov this fix introduced a typo/bug...
Yes your right :/ sorry. Also realised in both pulls (3.x and 2.5) we need to set mobile to true for CriOS. Will submit a PR later
I corrected already 2.5.x for $this->_agent
Two PR's reference above. New tracker item here: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30833
Fixed in 2.5.x. Thanks.