[#9580] - Implement countItems for extensions with sections
- Fixed in Code Base
- 29 Mar 2016
- Medium
- Build: staging
- # 9580
- Diff
- bembelimen:patch-15
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #9186
With 3.5 a new function was implemented in Joomla!: the items of a category can be counted via a helper method. The problem is, that this only works for basic category calls without sections because the extension string is not handled properly!
Summary of Changes
I moved the countItems stuff to its own method in the category and implemented a cleaner way for this function.
Testing Instructions
- Open the contact categories
- Change the link paameter to extension=com_contact.foobar
- create a new category
- no Counting visible, because Joomla! tries to load Contact.FoobarHelper class (pay attention to the ".")
- Apply path => Try again
Now extensions could use the second parameter "$section" to check for the correct items
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Components |
I tested this successfully - simulating sections via phpmyadmin as matrikular did.
I have tested this item 
successfully on 6ed19dd
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9580.
| Rel_Number | 0 | ⇒ | 9186 |
| Relation Type | ⇒ | Pull Request for |
@brianteeman can we get a RTC label here?
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
Thank you @bembelimen! This can be merged already for the next 3.5.1.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-29 11:01:02 |
| Closed_By | ⇒ | Kubik-Rubik |
| Labels |
Removed:
?
|
||
Sorry, I had to revert the merge because we are already in RC state and I should not have merged it.
@bembelimen Could you please do the same PR once again, then we can merge it into 3.5.2. Sorry for the inconvenience!
wilsonge
-
I have tested this item
successfully on 6ed19dd
Since without a component that supports sections one cannot really check if the count is still correct. I've tested this by assinging test contacts to that created category via phpmyadmin.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9580.