Joomla! Issue Tracker | Joomla! CMS #9575 - SEF: Change also empty href strings

Fixed in Code Base
25 Mar 2016
Medium
Build: staging
# 9575
Diff
andrepereiradasilva:patch-7

Success

Success continuous-integration/travis-ci/pr The Travis CI build passed Details
Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details

User tests: Successful: Unsuccessful:

andrepereiradasilva
24 Mar 2016

Pull Request for Issue #9554.

Summary of Changes

Solves issue #9554.

Testing Instructions

With 3.5.0 with SEF enabled in global configuration and SEF plugin enabled
Add to your template index.php (protostar for instance) the following code

<p>$this->baseurl: <a href="<?php echo $this->baseurl; ?>">without dash</a></p>
<p>$this->baseurl: <a href="<?php echo $this->baseurl; ?>/">with dash</a></p>
<p>JURI::root(): <a href="<?php echo JURI::root(); ?>">without dash</a></p>
<p>JURI::root(): <a href="<?php echo JURI::root(); ?>/">with dash</a></p>
<p>JURI::root(true): <a href="<?php echo JURI::root(true); ?>">without dash</a></p>
<p>JURI::root(true): <a href="<?php echo JURI::root(true); ?>/">with dash</a></p>
<p>JURI::base(): <a href="<?php echo JURI::base(); ?>">without dash</a></p>
<p>JURI::base(): <a href="<?php echo JURI::base(); ?>/">with dash</a></p>
<p>JURI::base(true): <a href="<?php echo JURI::base(true); ?>">without dash</a></p>
<p>JURI::base(true): <a href="<?php echo JURI::base(true); ?>/">with dash</a></p>

Check the resulting HTML

<p>$this->baseurl: <a href="">without dash</a></p>
<p>$this->baseurl: <a href="/">with dash</a></p>
<p>JURI::root(): <a href="https://domain.tld/">without dash</a></p>
<p>JURI::root(): <a href="https://domain.tld//">with dash</a></p>
<p>JURI::root(true): <a href="">without dash</a></p>
<p>JURI::root(true): <a href="/">with dash</a></p>
<p>JURI::base(): <a href="https://domain.tld/">without dash</a></p>
<p>JURI::base(): <a href="https://domain.tld//">with dash</a></p>
<p>JURI::base(true): <a href="">without dash</a></p>
<p>JURI::base(true): <a href="/">with dash</a></p>

Now apply this patch
Check the resulting html is:

<p>$this->baseurl: <a href="/">without dash</a></p>
<p>$this->baseurl: <a href="/">with dash</a></p>
<p>JURI::root(): <a href="https://domain.tld/">without dash</a></p>
<p>JURI::root(): <a href="https://domain.tld//">with dash</a></p>
<p>JURI::root(true): <a href="/">without dash</a></p>
<p>JURI::root(true): <a href="/">with dash</a></p>
<p>JURI::base(): <a href="https://domain.tld/">without dash</a></p>
<p>JURI::base(): <a href="https://domain.tld//">with dash</a></p>
<p>JURI::base(true): <a href="/">without dash</a></p>
<p>JURI::base(true): <a href="/">with dash</a></p>