[#9573] - Fix cloaking of email addresses in Contact category lists
- Fixed in Code Base
- 12 Apr 2016
- Medium
- Build: staging
- # 9573
- Diff
- aardgoose:fix-contact-email-cloaking
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Issue
Email cloaking in contact category component view does not work,
Steps to reproduce the issue
Set up a contact category menu item displaying a contact category containing contacts with email addresses. Make sure show email address is enabled for this menu item and the email cloaking plugin is enabled.
Expected result
The email address should be cloaked and if required prefixed with mailto:
Actual result
A plain uncloaked email address is shown.
Incorrect parameter name checked to determine if a contact's email address should be pre-processed before display.
Summary of Changes
"show_email_headings" checked instead of incorrect "show_email" parameter.
Email cloaking now works correctly
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Plugins |
Found in 3.4 but the fix equally applies to 3.5 (the code error is still there). If you look in default layout file category/tmpl/default_items.php it checks "show_email_headings", but the original view.html.php file checks "show_email" which doesn't work.
Are you looking at the contact email as displayed on the category listing page or a contact details. The problem is on the category listing page. This is with a standard installation.
I'm not clear what you are referring to by category listing page.
Here is a screen shot of what I'm looking at.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9573.
Hi, it looks like you are looking at the single contact display.
The Category list is referred to as "list contacts in a category" when you set up a new menu item.
The attached shows the correct behavior (the email addresses are highlighted because the mailto link has been added, and inspecting the page source shows that the cloaking java script is used for the display. Without the fix it is just a bare email address, no cloaking, no mailto link,
Thanks for looking at this.
I have tested this item 
successfully on 3bf4908
This is indeed a bug as show_email is used when displaying a unique contact and should not be the criteria to cloak emails in a contact category list.
Good find!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9573.
I have tested this item successfully on 3bf4908
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9573.
| Status | Pending | ⇒ | Ready to Commit |
RTC - thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9573.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-12 19:48:14 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
Hi,
I'm trying to test this fix but I cannot reproduce the issue. I disabled javascript and opened the contact and the email address was not shown(i.e it was cloaked).
P.S : is this issue there only in the new 3.5 version? I did the testing on the previous version.