? Success
Pull Request for # 8138

User tests: Successful: Unsuccessful:

avatar nishadi
nishadi
24 Mar 2016

Pull Request for Issue #8138

Summary of Changes

Added ordering Heading button
Added sort-able drag and drop button with drag and drop functionality
Added save ordering functionality to save the ordering when the items are sorted with drag and drop

Testing Instructions

  1. Go to Back end > Content > Articles
  2. Can sort the article items by drag and drop
  3. Go to Back end > Content > Featured Articles
  4. Can not sort the article items by drag and drop
  5. Apply the patch
  6. Go to Back end > Content > Featured Articles
  7. Now the view shows the drag and drop functionality
avatar nishadi nishadi - open - 24 Mar 2016
avatar nishadi nishadi - change - 24 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Mar 2016
Labels Added: ?
avatar brianteeman
brianteeman - comment - 24 Mar 2016

This seems to work but it is a little confusing (to me at least) as the number doesnt change on screen until after a page refresh


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9564.

avatar brianteeman brianteeman - change - 24 Mar 2016
Rel_Number 0 8138
Relation Type Pull Request for
avatar brianteeman brianteeman - change - 24 Mar 2016
Category Components Templates (admin)
avatar lunalars
lunalars - comment - 24 Mar 2016

I think the column "Ordering" should be removed completely (like at articles).


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9564.

avatar nishadi
nishadi - comment - 25 Mar 2016

I will update the PR according to the given feedback.

avatar JoshuaLewis
JoshuaLewis - comment - 25 Mar 2016

Subscribed. Let us know when this PR is updated.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9564.

avatar Webdongle Webdongle - test_item - 25 Mar 2016 - Tested unsuccessfully
avatar Webdongle
Webdongle - comment - 25 Mar 2016

I have tested this item :red_circle: unsuccessfully on 8da42a6

Clicking the 'Ordering' column changes the sort by field correctly. But clicking the 'arrow' column doesn't change the sort by field correctly which prevents the drag/drop from working.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9564.

avatar joomla-cms-bot
joomla-cms-bot - comment - 25 Mar 2016

This PR has received new commits.

CC: @Webdongle


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9564.

avatar nishadi
nishadi - comment - 25 Mar 2016

I have updated the PR removing the ordering column as suggested and now the featured article listing looks exactly like the article listing.
Need clarifications on updating and normalization of the default ordering in featured articles.

Thanks

avatar Webdongle Webdongle - test_item - 25 Mar 2016 - Tested successfully
avatar Webdongle
Webdongle - comment - 25 Mar 2016

I have tested this item :white_check_mark: successfully on 1c6d138

Excellent. Acts exactly the same as the Articles page. Front end Featured Articles displays according to order in the featured drag/drop screen.

Full Success


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9564.

avatar lunalars lunalars - test_item - 25 Mar 2016 - Tested successfully
avatar lunalars
lunalars - comment - 25 Mar 2016

I have tested this item :white_check_mark: successfully on 1c6d138

Yup, as webdongle said.
Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9564.

avatar andrepereiradasilva
andrepereiradasilva - comment - 25 Mar 2016

@nishadi it seems fine now. thanks for your contributions.

I would make two modifications:

  • remove the sortable-group-id="<?php echo $item->catid; ?>" to allow to order across multiple categories. We are talking here about feature articles that can be across categories, right?
  • In the list filter xml i would put the fp.ordering ordering options in first place because it's the first column. That would normalize with the other table list view.

UPDATE see the 2 patches i made to your repository, if all ok for you, accept them.

avatar joomla-cms-bot
joomla-cms-bot - comment - 26 Mar 2016

This PR has received new commits.

CC: @lunalars, @Webdongle


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9564.

avatar joomla-cms-bot
joomla-cms-bot - comment - 26 Mar 2016

This PR has received new commits.

CC: @lunalars, @Webdongle


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9564.

avatar nishadi
nishadi - comment - 26 Mar 2016

@andrepereiradasilva
Thanks you for the PRs and clarifications. I have accepted them.

avatar andrepereiradasilva andrepereiradasilva - test_item - 26 Mar 2016 - Tested successfully
avatar Webdongle Webdongle - test_item - 26 Mar 2016 - Tested unsuccessfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 26 Mar 2016

@Webdongle sorry? my patch only removed the limitation do order between multiple categories, as it should be. Before the patch has limited to order with drag and drop in one category, after the patch you can order with drag and drop between several categories.

See ab1d799

Are you testing with this settings in the feature menu item?
image

avatar Webdongle
Webdongle - comment - 26 Mar 2016

@andrepereiradasilva when I tested before your pr was added the articles displayed correctly in the front end. It could have been the removal of the 'Ordering' column'. If @nishadi checks by removing each edit and setting the menu item 1 column then that should show which broke it

Also point of testing etiquette ... although it;s not your patch you have added to it. Therefore should your test results in the tracker be discounted ? I mean no disrespect by that question.

avatar andrepereiradasilva andrepereiradasilva - test_item - 26 Mar 2016 - Not tested
avatar andrepereiradasilva
andrepereiradasilva - comment - 26 Mar 2016

@andrepereiradasilva when I tested before your pr was added the articles displayed correctly in the front end. It could have been the removal of the 'Ordering' column'. If @nishadi checks by removing each edit and setting the menu item 1 column then that should show which broke it

ok, so no problem with my patch them.

Also point of testing etiquette ... although it;s not your patch you have added to it. Therefore should your test results in the tracker be discounted ? I mean no disrespect by that question.

Actually it makes perfectly sense. If i contributed to the PR i shouldn't mark test results. Thank you for the warning. I removed my test result.
I guess i need some lessons of "testing etiquette" :wink:

avatar Webdongle
Webdongle - comment - 26 Mar 2016

@andrepereiradasilva
settings 01

settings 02

settings 03

Same result with
settings 04

There is a Category order in the menu item edit screen and imho removing sortable-group-id="<?php echo $item->catid; ?>" messed up the way the Component reads the menu item settings.

Thae Category order Setting in the menu item edit screen may be redundant (I have yet to test) but methinks it is required. Because the webmaster may wish to display Category order first then other order per category.
e.g.

Cats
--- Moggies
--- Persians

Dogs
--- Alsations
--- Terrier

Therefore removing sortable-group-id="<?php echo $item->catid; ?>" breaks the usability in any case. And that change should be reverted.

This is not a 'knock' at your efforts. ... they are appreciated. Just that I test/post in a 'matter of fact' way without emotion.

avatar andrepereiradasilva
andrepereiradasilva - comment - 26 Mar 2016

@Webdongle
Check your backend column order (you are ordering by title there). You should be ordering by order.

image

image

image

avatar andrepereiradasilva
andrepereiradasilva - comment - 26 Mar 2016

@Webdongle

There is a Category order in the menu item edit screen and imho removing sortable-group-id="<?php echo $item->catid; ?>" messed up the way the Component reads the menu item settings.

That "Category order" option is for, when you have feature articles in several categories, order by that "Category order" first and then by "Article order" (the next field).

You can see that behaviour in https://github.com/joomla/joomla-cms/blob/staging/components/com_content/models/featured.php#L124-L130

My change does not change that. In fact, i made the change to allow the use of "Category order = No order" when you have feature articles in multiple categories, like it was before this PR.

avatar Webdongle Webdongle - test_item - 26 Mar 2016 - Tested successfully
avatar Webdongle
Webdongle - comment - 26 Mar 2016

I have tested this item :white_check_mark: successfully on 75cba61

Retested and Full Success


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9564.

avatar Webdongle
Webdongle - comment - 26 Mar 2016

@andrepereiradasilva

Yep ... that was it had wrong sort column. Have deleted my previous test result and added a successful one. Thanks for finding my PEBKAC

I know what the "Category order" option is for. Had to have breakfast before I had chance to test. I changed the category of one of the featured articles ... applying the patch had no adverse affect.

avatar andrepereiradasilva
andrepereiradasilva - comment - 30 Mar 2016

@lunalars can you test this again after latest changes so it has to successfully tests.

avatar lunalars lunalars - test_item - 30 Mar 2016 - Tested successfully
avatar lunalars
lunalars - comment - 30 Mar 2016

I have tested this item :white_check_mark: successfully on 75cba61

Tested on staging with test content: changed ordering is saved and articles are displayed accordingly.

(And sorry for being late)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9564.

avatar nishadi
nishadi - comment - 30 Mar 2016

Thanks for testing the PR

avatar brianteeman brianteeman - change - 31 Mar 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 31 Mar 2016

RTC - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9564.

avatar joomla-cms-bot joomla-cms-bot - change - 31 Mar 2016
Labels Added: ?
avatar rdeutz rdeutz - change - 13 Apr 2016
Milestone Added:
avatar rdeutz
rdeutz - comment - 2 May 2016

@nishadi cloud you please check the merge conflicts, thanks

avatar Kubik-Rubik
Kubik-Rubik - comment - 8 May 2016

Thank you for creating this. It’s been some time since you created this and there are now some merge conflicts that prevent a direct merge. To save time I have created a new Pull Request from your code and am closing this here.

Check #10313

avatar Kubik-Rubik Kubik-Rubik - change - 8 May 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-05-08 13:04:46
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 8 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 8 May 2016
avatar Kubik-Rubik Kubik-Rubik - close - 8 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2016
Labels Removed: ?
avatar brianteeman brianteeman - change - 9 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment