User tests: Successful: Unsuccessful:
Pull Request for Issue #8138
Added ordering Heading button
Added sort-able drag and drop button with drag and drop functionality
Added save ordering functionality to save the ordering when the items are sorted with drag and drop
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Rel_Number | 0 | ⇒ | 8138 |
Relation Type | ⇒ | Pull Request for |
Category | ⇒ | Components Templates (admin) |
I think the column "Ordering" should be removed completely (like at articles).
I will update the PR according to the given feedback.
Subscribed. Let us know when this PR is updated.
I have tested this item unsuccessfully on 8da42a6
Clicking the 'Ordering' column changes the sort by field correctly. But clicking the 'arrow' column doesn't change the sort by field correctly which prevents the drag/drop from working.
This PR has received new commits.
CC: @Webdongle
I have updated the PR removing the ordering column as suggested and now the featured article listing looks exactly like the article listing.
Need clarifications on updating and normalization of the default ordering in featured articles.
Thanks
I have tested this item successfully on 1c6d138
Excellent. Acts exactly the same as the Articles page. Front end Featured Articles displays according to order in the featured drag/drop screen.
Full Success
I have tested this item successfully on 1c6d138
Yup, as webdongle said.
Thanks!
@nishadi it seems fine now. thanks for your contributions.
I would make two modifications:
sortable-group-id="<?php echo $item->catid; ?>"
to allow to order across multiple categories. We are talking here about feature articles that can be across categories, right?UPDATE see the 2 patches i made to your repository, if all ok for you, accept them.
This PR has received new commits.
CC: @lunalars, @Webdongle
This PR has received new commits.
CC: @lunalars, @Webdongle
@andrepereiradasilva
Thanks you for the PRs and clarifications. I have accepted them.
@Webdongle sorry? my patch only removed the limitation do order between multiple categories, as it should be. Before the patch has limited to order with drag and drop in one category, after the patch you can order with drag and drop between several categories.
See ab1d799
Are you testing with this settings in the feature menu item?
@andrepereiradasilva when I tested before your pr was added the articles displayed correctly in the front end. It could have been the removal of the 'Ordering' column'. If @nishadi checks by removing each edit and setting the menu item 1 column then that should show which broke it
Also point of testing etiquette ... although it;s not your patch you have added to it. Therefore should your test results in the tracker be discounted ? I mean no disrespect by that question.
@andrepereiradasilva when I tested before your pr was added the articles displayed correctly in the front end. It could have been the removal of the 'Ordering' column'. If @nishadi checks by removing each edit and setting the menu item 1 column then that should show which broke it
ok, so no problem with my patch them.
Also point of testing etiquette ... although it;s not your patch you have added to it. Therefore should your test results in the tracker be discounted ? I mean no disrespect by that question.
Actually it makes perfectly sense. If i contributed to the PR i shouldn't mark test results. Thank you for the warning. I removed my test result.
I guess i need some lessons of "testing etiquette"
There is a Category order in the menu item edit screen and imho removing sortable-group-id="<?php echo $item->catid; ?>" messed up the way the Component reads the menu item settings.
Thae Category order Setting in the menu item edit screen may be redundant (I have yet to test) but methinks it is required. Because the webmaster may wish to display Category order first then other order per category.
e.g.
Cats
--- Moggies
--- Persians
Dogs
--- Alsations
--- Terrier
Therefore removing sortable-group-id="<?php echo $item->catid; ?>" breaks the usability in any case. And that change should be reverted.
This is not a 'knock' at your efforts. ... they are appreciated. Just that I test/post in a 'matter of fact' way without emotion.
@Webdongle
Check your backend column order (you are ordering by title there). You should be ordering by order.
There is a Category order in the menu item edit screen and imho removing sortable-group-id="<?php echo $item->catid; ?>" messed up the way the Component reads the menu item settings.
That "Category order" option is for, when you have feature articles in several categories, order by that "Category order" first and then by "Article order" (the next field).
You can see that behaviour in https://github.com/joomla/joomla-cms/blob/staging/components/com_content/models/featured.php#L124-L130
My change does not change that. In fact, i made the change to allow the use of "Category order = No order" when you have feature articles in multiple categories, like it was before this PR.
I have tested this item successfully on 75cba61
Retested and Full Success
Yep ... that was it had wrong sort column. Have deleted my previous test result and added a successful one. Thanks for finding my PEBKAC
I know what the "Category order" option is for. Had to have breakfast before I had chance to test. I changed the category of one of the featured articles ... applying the patch had no adverse affect.
I have tested this item successfully on 75cba61
Tested on staging with test content: changed ordering is saved and articles are displayed accordingly.
(And sorry for being late)
Thanks for testing the PR
Status | Pending | ⇒ | Ready to Commit |
RTC - thanks
Labels |
Added:
?
|
Milestone |
Added: |
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-08 13:04:46 |
Closed_By | ⇒ | Kubik-Rubik |
Labels |
Removed:
?
|
Milestone |
Removed: |
This seems to work but it is a little confusing (to me at least) as the number doesnt change on screen until after a page refresh
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9564.