1. Shouldnt it be an error not a warning
2. How about "The mcrypt php extension is needed before you can enable Two Factor Authentication."
3. Please alpha-order the new string

done, done and done

I noticed now that we still need to add this check in the frontend too.

ok done

Looks fine to me...

I have just send you a CS fix. This is on my testing list for this afternoon ;) andrepereiradasilva#43

sorry one more andrepereiradasilva#44

I have tested this item successfully on 7a6bbfa

Good one. Thanks. To the tester please note that the message is now an error and not a warning as on the screenshot.

@icampus
I have tested this item unsuccessfully.
I wasn't able to reproduce the warning.
After i install Google Authenticator Two Factor Authentication everything worked well and i not get a warning popup.

@Schmidie64 are you sure you were able to disable mcrypt? Did phpinfo confirm it? I know I was never able to successfully disable it on my system

I have tested this item ? unsuccessfully on 7a6bbfa

@icampus
I have tested this item unsuccessfully.
I wasn't able to reproduce the warning.
After i install Google Authenticator Two Factor Authentication everything worked well and i not get a warning popup.

I tested @icampus

How did you disable mcrypt on your system ?
I tried it on linux and had no success.

With mcrypt everything is working fine.

go to your php.ini look for this

extension=mcrypt.so

comment it

; extension=mcrypt.so

restart your apache/php or php-fpm server

The php.ini doesn't contain this line.

"_[mcrypt]
; For more information about mcrypt settings see http://php.net/mcrypt-module-open

; Directory where to load mcrypt algorithms
; Default: Compiled in into libmcrypt (usually /usr/local/lib/libmcrypt)
;mcrypt.algorithms_dir=

; Directory where to load mcrypt modes
; Default: Compiled in into libmcrypt (usually /usr/local/lib/libmcrypt)
;mcrypt.modes_dir=_"

search for mcrypt in your php ini files, you will find something like extension = mcrypt.something it can deffer across Operating systems. That is the line you have to comment

I found it on php.ini-pre1.7.2 and it was already comment

Managed to disable mcrypt this time not sure what I was doing wrong before and confirmed the fatal error

Unfortunately after applying the patch I still get the following fatal errors when I try to edit the user

[02-Aug-2016 13:31:54 Europe/London] PHP Notice: Use of undefined constant MCRYPT_RIJNDAEL_256 - assumed 'MCRYPT_RIJNDAEL_256' in /Applications/MAMP/htdocs/github-joomla-cms/libraries/fof/encrypt/aes.php on line 44
[02-Aug-2016 13:31:54 Europe/London] PHP Notice: Use of undefined constant MCRYPT_MODE_CBC - assumed 'MCRYPT_MODE_CBC' in /Applications/MAMP/htdocs/github-joomla-cms/libraries/fof/encrypt/aes.php on line 63
[02-Aug-2016 13:31:54 Europe/London] PHP Fatal error: Call to undefined function mcrypt_get_iv_size() in /Applications/MAMP/htdocs/github-joomla-cms/libraries/fof/encrypt/aes.php on line 144

maybe it's because of the conflicts... i need to fix and check first
will try to do this tonight.

@andrepereiradasilva could you check this please - also as fof has been updated you might not even need this PR anymore

Still needed as it's adding checks for a scenario when mcrypt isn't installed or enabled on the system. Just needs rebased first to see where things are at.

yes i can solve the conflict, but know the 2FA exists in some more places.
have to check then all later.

conflicts fixed.
ready to test.

please test so i don't need to fix conflicts yet again.

ok, sorry for that, but needed to solve additional issues.

Ready for tests

@brianteeman can you test?

I have tested this item ✅ successfully on 979004b

thanks @brianteeman

coorected text string as @mbabker comments

#11673 This should have been fixed with this FOF update

yes, it seems fixed. so no needs for mcrypt anymore right?

@wilsonge @mbabker if joomla now does not need mcrypt so #9508 AND #9532 should be reverted, and of course, this closed.

I guess it depends if the other libraries michael mentioned have since been patched?

ok, i see there is an issue for that #11398, will post there