[#9519] - Ensure com_content models are in lookup path
- Closed
- 22 Mar 2016
- Medium
- Build: staging
- # 9519
- Diff
- mbabker:mod-related-items-fix
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue http://forum.joomla.org/viewtopic.php?f=710&t=913801&sid=d3a6b0d7e369a88213a0687721a77233
Summary of Changes
The related items module uses com_content to find items but does not ensure the com_content models are in the lookup path or validate the $articles assignment is a model object. This is corrected. As well, all returns in error conditions now match the documented return type of array.
Testing Instructions
Ensure the related items module functions as designed (sorry, I've never used it so couldn't tell you how it works, but from the code alone and knowing how Joomla doesn't autoload components it's easy to see how this would break on a non-com_content page).
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Rel_Number | 0 | ⇒ | 9518 |
| Relation Type | ⇒ | Pull Request for |
| Milestone |
Added: |
||
| Milestone |
Added: |
||
I have tested this item 
successfully on b09ad62
This PR solves the issue. However, looking at the code, I see that the module will only be displayed on article detail page. So maybe we should move most of the code in the method into if block https://github.com/joomla/joomla-cms/blob/staging/modules/mod_related_items/helper.php#L58 ?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9519.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-22 13:40:25 |
| Closed_By | ⇒ | wilsonge |
Merged on review
I have tested this item
successfully on b09ad62
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9519.