[#9512] - Improve clarification on how to use the banned fields in Contacts.
- Fixed in Code Base
- 12 Apr 2016
- Medium
- Build: staging
- # 9512
- Diff
- joomla:improve-contact-banned-tooltip
- Success continuous-integration/travis-ci/push The Travis CI build passed Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
When users are editing a contact on the Form tab they can add banned email/subject/words. It is unclear how to separate multiple values. This change updates the tooltip with this information.
Testing Instructions
- Go to Components -> Contacts
- Click on New
- Go to the Form tab and check the tooltip for Banned Email, Banned Subject and Banned Text. There is no mentioning on how to enter multiple values.
- Apply the patch
- Go to Components -> Contacts
- Click on New
- Go to the Form tab and check the tooltip for Banned Email, Banned Subject and Banned Text. The tooltip now shows how to enter multiple values.
| Milestone |
Added: |
||
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Category | ⇒ | Components Language & Strings |
| Milestone |
Added: |
||
| Labels | |||
I took a quick look and the strings are fine. I just wanted to check that it was a semi-colon that was the separator or not
If you have a banned word in the subject is it still supposed to say "sent email"
I don't think it is because it doesn't send anything glancing over the code. That would be a separate PR though to deal with that issue.
I have tested this item 
successfully on 5584664
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9512.
Its ok - I was just looking to see ghat it was a semi-colon and not a colon - i couldnt find the code but I have done now
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9512.
| Status | New | ⇒ | Pending |
I have tested this item successfully on 5584664
Thanks
Maybe an already fixed question but what about adding: (;)
for non-native speakers that stay in en-GB, this maybe could help. Thoughts?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9512.
There is no easy way to do that and tbh if we were to do it here we would
need to do it in a LOT of other places. Those are the sort of changes that
the TT scream about
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
| Labels |
Added:
?
|
||
Let's leave it as-is then :)
| Labels |
Removed:
?
|
||
| Milestone |
Added: Removed: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
Setting as RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9512.
| Labels |
Added:
?
|
||
Why setting the milestone to 3.5.2?
Because with all the issues we need a small 3.5.1 without language string changes ;)
because 3.5.1 will be within the next x hours and its a language change so
that wont give the TT long enough to translate
I did not know, so no lang change in 3.5.1, right?
right
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-12 19:47:03 |
| Closed_By | ⇒ | rdeutz |
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
| Labels |
Removed:
?
|
||
@brianteeman Brian, pinging you since you are the native speaker :)