[#950] - Cleanup of unused variables
- Closed
- 20 Jun 2013
- Medium
- Build: master
- # 950
- Diff
- unknown repository
- Foreign ID 30479
- Success default The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Tracker ID: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30479
The php code is riddled with variables that are not being used. Probably left-overs from old and removed code. Or simply bad programming practises (like initializing the variable when it is always set in later code).
Anyway, this PR removes the bulk of those unused (memory/resource/time-hogging) variables.
Changes this PR brings:
- Removal of unused variables
- Some syntax cleanup
- Some fixes in the tests (to deal with syntax cleanup)
Testing instructions
This probably just needs the general system tests to see if it doesn't break anything.
Here's the tracker item for it:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30479
Thanks again, Peter!
All synced up again :)
nice :)
Let me know any time you want to lock the branch for this.
Then I can create a general syntax cleanup PR too... ;)
Needs to be synced up once again.
@dextercowley could you run the system tests on this after it is synced up?
Yes. Please let me know when it's ready. Thanks.
All synced up
Any chance of this ever getting pulled?
I'd like to see it merged. I think if we can get the system tests run one more time and they pass, that should give us a go ahead.
I'll run the system tests and post a comment. Mark
On Sat, Jun 15, 2013 at 9:27 AM, Michael Babker notifications@github.comwrote:
I'd like to see it merged. I think if we can get the system tests run one
more time and they pass, that should give us a go ahead.—
Reply to this email directly or view it on GitHub#950 (comment)
.
Thanks Peter! :)
lol, submitted 8 minutes ago and it's already out of sync.