?
Referenced as Pull Request for: # 9889
avatar brianteeman
brianteeman
20 Mar 2016

We are using v1.2.4 current version is 1.4.1
https://github.com/bestiejs/punycode.js

avatar brianteeman brianteeman - open - 20 Mar 2016
avatar wilsonge
wilsonge - comment - 20 Mar 2016

You want to give it a go - it should be as simple as replacing the two files with the ones from the github repo there :)

avatar brianteeman
brianteeman - comment - 20 Mar 2016

I tried and messed up my repo. No idea why. Can try again tomorrow I guess
but it will take a while to fix the repo
On 20 Mar 2016 9:36 pm, "George Wilson" notifications@github.com wrote:

You want to give it a go - it should be as simple as replacing the two
files with the ones from the github repo there :)


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#9497 (comment)

avatar infograf768
infograf768 - comment - 21 Mar 2016

There are 2 files to replace, the minified one which has to be renamed to uncompressed, and the compressed one.
also I guess it has to be tested. I just have to remember when we use it... :cactus:

avatar brianteeman
brianteeman - comment - 21 Mar 2016

When 3.5 is released I will try to rebuild my repo and do the PR unless
someone has done it first

On 21 March 2016 at 11:24, infograf768 notifications@github.com wrote:

There are 2 files to replace, the minified one which has to be renamed to
uncompressed, and the compressed one.
also I guess it has to be tested. I just have to remember when we use
it... [image: :cactus:]


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#9497 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar infograf768
infograf768 - comment - 21 Mar 2016

I now found out what it is used for (IDN email validation)

See #2788

avatar infograf768
infograf768 - comment - 21 Mar 2016

We will have to test a change we did in #3429

-               value = punycode.encode(value);
+               value = punycode.toASCII(value);

in validate.js
as there were some changes in punycode.js

avatar brianteeman brianteeman - change - 8 Apr 2016
Status New Confirmed
avatar brianteeman brianteeman - change - 13 Apr 2016
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2016-04-13 11:05:39
Closed_By brianteeman
avatar brianteeman
brianteeman - comment - 13 Apr 2016

Closed see #9889


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9497.

avatar brianteeman brianteeman - close - 13 Apr 2016
avatar brianteeman brianteeman - close - 13 Apr 2016

Add a Comment

Login with GitHub to post a comment