Joomla! Issue Tracker | Joomla! CMS #9493 - Profile plugin - check that dob is not in the future

?

Fixed in Code Base
21 Mar 2016
Medium
Build: staging
# 9493
Diff
alikon:patch-61

Success

Success continuous-integration/travis-ci/pr The Travis CI build passed Details
Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details

User tests: Successful: Unsuccessful:

alikon
20 Mar 2016

Pull Request for Issue #9460.

Summary of Changes

added a check that dob is less than now

Testing Instructions

enable profile plugin
and set as required date of birth
unable to register if the date of birth is in the future #9460

98fd7dc 20 Mar 2016

Profile plugin - disallow to register dob in the future

alikon - open - 20 Mar 2016

alikon - change - 20 Mar 2016

Status

New

⇒

Pending

joomla-cms-bot - change - 20 Mar 2016

Labels

Added: ?

alikon - change - 20 Mar 2016

Title

…

Profile plugin - check that dob is not the future

Profile plugin - check that dob is not in the future

brianteeman - test_item - 20 Mar 2016 - Tested successfully

brianteeman - comment - 20 Mar 2016

I have tested this item successfully on 98fd7dc

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9493.}

waader - test_item - 20 Mar 2016 - Tested successfully

waader - comment - 20 Mar 2016

I have tested this item successfully on 98fd7dc

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9493.}

MATsxm - test_item - 20 Mar 2016 - Tested successfully

MATsxm - comment - 20 Mar 2016

I have tested this item successfully on 98fd7dc

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9493.}

bb4b324 20 Mar 2016

change of function call for 'now'

joomla-cms-bot - comment - 20 Mar 2016

This PR has received new commits.

CC: @brianteeman, @MATsxm, @waader

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9493.}

MATsxm - test_item - 20 Mar 2016 - Tested unsuccessfully

MATsxm - comment - 20 Mar 2016

I have tested this item unsuccessfully on bb4b324

In fact: Tested successfully
BUT
The thing is that in backend we have an Error class="alert alert-error"
and on frontend we have a Warning class="alert" that should be an error when setting as required.

Thanks

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9493.}

alikon - comment - 21 Mar 2016

@MATsxm this pr doesn't change the formerly beahviour of the user registration form, for example,
when you try to register a new user with a username already registered this is what i get

...so can be out of scope of this pr ,maybe matter for another pr ?

MATsxm - comment - 21 Mar 2016

Hmmm
I would agree but if for the same action you have 2 different results just because you are on frontend or backend.... I would say there's a problem somewhere.
Like I said, the expected result is ok: you can't register with a dob in the future.
but then I will open an issuefor this:
Backend:

Frontend:

MATsxm - test_item - 21 Mar 2016 - Tested successfully

MATsxm - comment - 21 Mar 2016

I have tested this item successfully on bb4b324

Return to "Successful" and opened #9502 concerning the error messages.
Thanks

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9493.}

nikitadhiman - test_item - 21 Mar 2016 - Tested successfully

nikitadhiman - comment - 21 Mar 2016

I have tested this item successfully on bb4b324

patch works fine!

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9493.}

wilsonge - change - 21 Mar 2016

Status	Pending	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2016-03-21 13:02:06
Closed_By		⇒	wilsonge

wilsonge - close - 21 Mar 2016

wilsonge - merge - 21 Mar 2016

wilsonge - reference | 5822d4f - 21 Mar 16

wilsonge - merge - 21 Mar 2016

wilsonge - close - 21 Mar 2016

wilsonge - change - 21 Mar 2016

Milestone

Added:

Add a Comment

Login with GitHub to post a comment

Older
Newer