? Success

User tests: Successful: Unsuccessful:

avatar photodude
photodude
19 Mar 2016

Pull Request to Add Microdata to popular articles.

Summary of Changes

Adds hard coded Microdata to popular articles following the format established in the latest articles module

Testing Instructions

  1. Add patch https://docs.joomla.org/Testing_Joomla!_patches
  2. Add a popular articles module to a view
  3. Check that microdata values are applied using a microdata validation tool such as https://developers.google.com/structured-data/testing-tool/

Additional Comments

With the JMicrodata PR's #8934 and #8933 in review, this PR is proposed to add the hard coded Microdata values so that schema.org markup can be added in the short term.

The does not replace #8934, nor is it an alternative. This PR is just a solution to put in place the missing Microdata values while the change to use the JMicrodata library is in Review.

Votes

# of Users Experiencing Issue
0/1
Average Importance Score
4.00

avatar photodude photodude - open - 19 Mar 2016
avatar photodude photodude - change - 19 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Mar 2016
Labels Added: ?
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Mar 2016

Titles not linked
Without Patch you see linked Titles in Module "Articles - Most Read":
without-patch-fe
With Patch unlinked Titles:
patch-fe

Testing Tools Failure
Without Patch you see no Module Failure (Failures only in "Article")
without-patch
With Patch there are Failures:
patch

avatar brianteeman brianteeman - change - 19 Mar 2016
Category Modules
avatar brianteeman brianteeman - test_item - 19 Mar 2016 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 19 Mar 2016

I have tested this item :red_circle: unsuccessfully on 0e90632

breaks links as noted above


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9474.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 19 Mar 2016 - Tested unsuccessfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Mar 2016

I have tested this item :red_circle: unsuccessfully on 0e90632


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9474.

avatar joomla-cms-bot
joomla-cms-bot - comment - 19 Mar 2016

This PR has received new commits.

CC: @brianteeman, @franz-wohlkoenig


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9474.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 19 Mar 2016 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Mar 2016

I have tested this item :white_check_mark: successfully on ca0b09f


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9474.

avatar coolman01
coolman01 - comment - 19 Mar 2016

I have tested this item :white_check_mark: successfully on localhost


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9474.

avatar nikitadhiman nikitadhiman - test_item - 20 Mar 2016 - Tested successfully
avatar nikitadhiman
nikitadhiman - comment - 20 Mar 2016

I have tested this item :white_check_mark: successfully on ca0b09f

The patch works fine!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9474.

avatar photodude
photodude - comment - 20 Mar 2016

@brianteeman Can this be set to RTC now?

avatar photodude
photodude - comment - 24 Mar 2016

@wilsonge @mbabker could someone mark this RTC now that we have successful human tests?

avatar wilsonge wilsonge - close - 25 Mar 2016
avatar wilsonge wilsonge - merge - 25 Mar 2016
avatar wilsonge wilsonge - change - 25 Mar 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-03-25 15:11:58
Closed_By wilsonge

Add a Comment

Login with GitHub to post a comment