Thankyou Nic. Very very very much appreciated. Testers await my testing instructions that I will write this evening

I have tested this item unsuccessfully on 2137111

I just have made a 1st test and seen that after I selected FTP mode as installation method in the new Upload & Update tab, there is nowehere in the procedure coming up fields to enter FTP access information (user, password, server and so on), like it would be with the "Live Update", also not after upload has finished ans logij information has been entered. The update fails then with invalid ftp account information error. It then seems to use defaults (Joomla! actual admin user name and password and localhost), not the valid FTP account data from global config or anything which could be entered during the process. The Hybrid mode I did therefore not test.

So FTP mode did not work, writing files directly did work.

I "updated" a 3.5.0.-rc4 to a 3.5.0.-rc4, means it finally was what you call reinstall, but there is no option for it, it only means to update with package of same version as installed one, using the new "Upload & Update" functionality.

Clear your browser cache. Otherwise your browser loads the old JavaScript. The new JavaScript shows the fields just fine.

Right after installation Joomla! clears all update information. Click the Clear Cache button OR wait for six hours to see the reinstall (we have to reload the update information).

I have not tested this item.

I change back to untested, have to solve somethine else then can test again. Sorry for the rumor, Nik.

@nikosdion I also have the problem which @zero-24 mentioned, that your PR removes administrator/manifests/packages/pkg_weblinks.xml from the repo.

This makes it a problem to apply this patch with patchtester, and also is not good for the repo at the end.

nikosdion#1 Fixes for travis and adding back the weblinks package

This PR has received new commits.

CC: @richard67

This PR has received new commits.

CC: @richard67

Travis fails:
FILE: ...dministrator/components/com_joomlaupdate/views/default/tmpl/default.php

FOUND 1 ERROR(S) AFFECTING 1 LINE(S)

19 | ERROR | Opening parenthesis of a multi-line function call must be the

|       | last content on the line

UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY

FILE: ...rator/components/com_joomlaupdate/views/default/tmpl/default_upload.php

FOUND 2 ERROR(S) AFFECTING 2 LINE(S)

15 | ERROR | Opening parenthesis of a multi-line function call must be the

|       | last content on the line

47 | ERROR | Opening parenthesis of a multi-line function call must be the

|       | last content on the line

UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY

Testing instructions please

Patch applied and i have a stray

echo JHtml::_('form.token');

This PR has received new commits.

CC: @richard67

I fully understand why we are asked to confirm our admin details before continuing BUT does it need to have the password/username reminder functionality (which opens the frontend of the site)

The form was copied from the (backend!) login module.

FTP Mode
Is there a reason that the field names are different to the ones in global
configuration? Specifically FTP folder which is called FTP root in the
global configuration

Also it will be really useful if the tooltips we can see in global
configuration for ftp are used here as well.

Thanks

On 19 March 2016 at 08:27, Nicholas K. Dionysopoulos <
notifications@github.com> wrote:

The form was copied from the (backend!) login module.

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#9469 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Where are the testing instructions please ?

I have tested this item successfully on 71c9469

OK I think I worked it out
With 3.5.0rc
Used Patchtester to apply the patch
Joomla Update 'Testing' channel found the update to 3.5.0rc4
Switched tabs and browsed and updated
Full Success

With 3.5.0rc4
Used Patchtester to apply the patch
Joomla Update switched tabs and browsed and installed the 3.5.0rc4 full package
Full Success

I have tested this item unsuccessfully on 71c9469

FTP option don't shown if selected.

In the code we have checks for $this->ftpFieldsDisplay but this is always style = "display: none".

I have tested to switch the Global FTP Option to enabled -> use the dropdown and say Use FTP -> the ftp host / pw etc don't show up.

I get the error message that the FTP User is not set (correct as it is not set in Global Config) but i expect (from code) that there are fields to enter that infos if we choose FTP?

I have not tested this item.

fixed by cleaning the cache. Thanks

Testing under postgres I get

0 ERROR: invalid input syntax for integer: "" LINE 6: WHERE "last_check_timestamp" = '' OR "last_check_timestamp" ... ^SQL=SELECT DISTINCT update_site_id FROM #__updates WHERE "update_site_id" IN ( SELECT update_site_id FROM #__update_sites WHERE "last_check_timestamp" = '' OR "last_check_timestamp" <= '1458373952')

I still have the problem that FTP options are shown now, but I get message about invalid server or port, and this cannot be because have correct info about that entered in the form and also have it correct for ftp layer in gloabl settings. My host offers old (unsecure) ftp only, port 21. Can it be that here sftp, port 22, is required? Or still something wrong with the ftp stuff?

Another thing I think about is that after a successful update to an unpatched version, the changes made by this PR will be lost, so maybe someone (or me) should provide an update container for RC4 patched with this PR (for tests starting with an RC3 patched by this PR).

Let me know if it makes sense and I shall pack such container. Could provide it for donwload on my domain then.

Sorry, I don't have any more time to deal with it. After a brief discussion with @wilsonge I am handing it over to him. I am closing the PR but I'm leaving the branch in my repo for him to continue work.

Regarding FTP, it does work, as long as you have also enabled FTP in Global Configuration and you use plain old insecure FTP (NOT SFTP, NOT FTPS – these are not supported). Please note that in case your host only offers SFTP, both SFTP and direct file writes run under the same user, therefore it makes no sense supporting it. FTPS only makes sense to use as an alternative to FTP only when accessing the server over the Internet, i.e. when the password is transferred over an insecure network. Again, it makes no sense to support it.

Having Joomla! Update require the FTP layer to be enabled to use FTP is not something I like at all, it was imposed on me when I pulled my code out of Admin Tools and contributed it as Joomla! Update all those years ago.

In any case, if someone needs to use FTP without the FTP layer they can use Akeeba CMS Update. Just hold on until later today, I am currently working towards releasing a new version that deals with the nonstandard release candidate naming in 3.5.0. As for the last 2 years, Akeeba CMS Update has full FTP and reinstall support. Reinstall seems to work better than Joomla! Update since I rely on my code to parse updates, not JUpdater (apparently I dodged the PostgreSQL bullet in CMS Update by doing so). Stupidly, I cannot use that code –even though it's part of FOF which is part of Joomla!– because even though Joomla! begged me to included FOF in the core they promptly forbade anyone from using FOF for core code. Awkward...Anyway, Akeeba CMS Update doesn't have an upload and install feature yet, so you'd better fix this Joomla! Update PR for 3.5.0.

I have tested this item successfully on localhost using Joomla version, 3.5.0-rc4.

The reinstall info showed in the joomla update component and the update was reinstalled with no problems

@nikosdion Ahhh, I did not have ftp layer enabled in global config, sorry, my mistake. Have it on all my test sites except this one I used here. Now it makes sense. And with sftp or ftp you might have got me wrong, I use ftp and not assumed sftp was right, just wanted to ask to be sure.

Sorry it I somehow annoyed or confused or discouraged you so you closed this PR. I am just testing with ftp and if this works I will mark test result as ok here because everything worked, so even if this is closed @wilsonge will know it worked for me.

No, honestly Richard, nobody annoyed me. I have just already spend twice as much time as I had budgeted and I found myself on a Saturday evening, having to release a lot of software by Monday. Oops.

Ah, ok. Thanks for all you did, and I wait for news from George regarding testing.

If this thread is referenced in the ne pr ... then we should get an email yes ?