@brianteeman A minor note, #9454 has "label:3.5.0-blocker". Does this one inherit the same label?

@wilsonge added the blocker tag - i guess it makes sense it is here as well. Added

@dgt41 @ggppdk please, test to confirm it is a viable fix.

I have tested this item successfully on cdce08d

I pasted the code snippet between php tags at the end of administrator/components/com_users/views/user/tmpl/edit.php, but also at the end of administrator/templates/hathor/html/com_users/user/edit.php before last closing div.

Before patch: Works for Hathor but not for Isis.

After patch: Works for both Hathor and Isis.

@anibalsanchez I get an error for normal form fields:

May I ask why you don't do something like:

$idTag = 'form_name';
$extraData = array(
    'disabled'      => false,
    'value'         => '',
    'asset'         => 'asset',
    'readonly'      => false,
    'id'            => 'someId',
    'name'          => 'name',
    'authorField'   => 'author',
    'authorId'      => JFactory::getUser()->id,
    'folder'        => '',
    'link'          => 'index.php?option=com_media&view=images&tmpl=component&asset=com_users&author=' . JFactory::getUser()->id . '&fieldid=' . $idTag,
    'preview'       => '',
    'previewHeight' => '',
    'previewWidth'  => '',
);

echo JLayoutHelper::render('joomla.form.field.media', $extraData);

This way you don;t mess mess with the internals of the field and it will work fine in all cases

@dgt41 maybe a stupid question... (as you mention "don't ask" when you added it ;-) ) but why there are overrides for form fields layouts inside Isis ?... (i don't understand the reason, and the logic... sorry if a stupid question... or not...)

@JoomliC The root/layouts file is the one with mootools modal, the overrides are the ones for bootstrap. The difference is that the bootstrap javascript is different than that we had for mootools and the reason was to make it compatible with the new repeatable field.
Also (if I am not mistaken) the bootstrap also got tabs for selecting or uploading a file

@dgt41 Ok! Thanks!
A reason to keep in core the mootools, and not replacing it by the bootstrap one ? (as we know since the very first Joomla 3 that mootools should be removed ? (curiosity...)

I thought that will be B/C, because there are templates out there that don't use bootstrap (although we can load it in the field :( )

@dgt41Sure, this media button call can be improved with the latest JLayouts improvements.

I have submitted the issue to fix the legacy API support. I guess there are many extensions still implementing the old way.

@dgt41 About the console error, I've been unable to reproduce it. It can be fixed in this way:

                        <button class="btn btn-success button-save-selected" type="button" onclick="<?php if ($this->state->get('field.id')):?>((window.parent.jInsertFieldValue) && (window.parent.jInsertFieldValue(document.getElementById('f_url').value,'<?php echo $this->state->get('field.id');?>')));<?php else:?>ImageManager.onok();<?php endif;?>window.parent.jModalClose();window.parent.jQuery('.modal.in').modal('hide');" data-dismiss="modal"><?php echo JText::_('COM_MEDIA_INSERT') ?></button>

But, it also affects media/images (from where I copy/pasted the button).

5'... I'm adding the condition.

This PR has received new commits.

CC: @richard67

@anibalsanchez can you update protostar layout as well?

This PR has received new commits.

CC: @richard67

This PR has received new commits.

CC: @richard67

Ready to be tested. @richard67 @dgt41 @JoomliC @ggppdk

Cases:

• Backend. New article, image selection from editor
• Backend. New article, image selection to Intro Image field
• Frontend. New article/post, image selection from editor
• Frontend. Module edition, image selection from editor
• Backend. Custom field with image selection. Test in User edition as detailed above.

  ---

  _{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9466.}

I have tested this item successfully on 6fab638

Tested all test cases mentioned in comment above.

Works as desired, no php errors or warning with maximum error reporting.

I have tested this item successfully on 6fab638

- Backend. New article, image selection from editor

• Backend. New article, image selection to Intro Image field
• Frontend. New article/post, image selection from editor
• Frontend. Module edition, image selection from editor
• Backend. Custom field with image selection. Test in User edition as detailed above.

Worked as described - Thanks!

RTC

I have tested this item successfully on 6fab638

Tested cases, and other extensions using image field, with success.

After discussion with @dgt41 we are just going to remove the template overrides for b/c reasons and stick with the mootools stuff

:( Thats a shame the change to using separate tabs was an improvement

On 20 March 2016 at 18:29, George Wilson notifications@github.com wrote:

After discussion with @dgt41 https://github.com/dgt41 we are just going
to remove the template overrides for b/c reasons and stick with the
mootools stuff

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9466 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/