? Success

User tests: Successful: Unsuccessful:

avatar pritalpatel
pritalpatel
17 Mar 2016

Adding help to test joomla cms
This changes will guide user to see tests folder if they want to know how to test joomla-cms.

avatar pritalpatel pritalpatel - open - 17 Mar 2016
avatar pritalpatel pritalpatel - change - 17 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Mar 2016
Labels Added: ?
avatar brianteeman
brianteeman - comment - 17 Mar 2016

I really dont think this is a good idea - it could confuse people as the readme is distributed in the CMS but the tests folder is not.

avatar brianteeman
brianteeman - comment - 17 Mar 2016

Also any change made to readme.md will also have to be made to readme.txt

avatar zero-24
zero-24 - comment - 17 Mar 2016

@brianteeman the reademe.md is not shipped withe the CMS stable. It is just the description text for the repo ;)

If we want to add it i think we should write something that the tests folder contain the system and unit tests. General patch testing or just simple testing don't require that tests folder :)

avatar brianteeman
brianteeman - comment - 17 Mar 2016

Readme.txt is shipped and the two files really should be the same but as
you state @zero24 if something is going to be added then the proposed text
really isnt fit for the prupose

On 17 March 2016 at 19:37, zero-24 notifications@github.com wrote:

@brianteeman https://github.com/brianteeman the reademe.md is not
shipped withe the CMS stable. It is just the description text for the repo
;)

If we want to add it i think we should write something that the tests
folder contain the system and unit tests. General patch testing or just
simple testing don't require that tests folder :)


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9456 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar pritalpatel
pritalpatel - comment - 18 Mar 2016

Thanks for review. I have changed texts and tried to make it more informative.
My purpose behind adding this help is that, when I have started reading this doc I didn't get idea to go to tests folder if I want to execute and find tests suits for unit or system testing.

avatar Bakual
Bakual - comment - 18 Mar 2016

Personally, I think anyone who is able to actually run those tests, will have no problems figuring out that the tests are in that folder.

avatar andrepereiradasilva
andrepereiradasilva - comment - 19 Mar 2016

i also don't agree with this for most people test is testing the patches, in other words, using the patchtester for that, not the kind of tests described here.

avatar brianteeman brianteeman - close - 19 Mar 2016
avatar brianteeman
brianteeman - comment - 19 Mar 2016

@pritalpatel Thanks for your contribution but I am closing this for the reasons stated above

avatar brianteeman brianteeman - change - 19 Mar 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-03-19 13:43:20
Closed_By brianteeman
avatar brianteeman brianteeman - close - 19 Mar 2016
avatar pritalpatel pritalpatel - head_ref_deleted - 19 Mar 2016
avatar pritalpatel
pritalpatel - comment - 19 Mar 2016

NP. I understand. Thanks for review.

Add a Comment

Login with GitHub to post a comment