? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
15 Mar 2016

Pull Request for Issue #9438.

Summary of Changes

added if required of course

Testing Instructions

Comment

mea culpa

avatar alikon alikon - open - 15 Mar 2016
avatar alikon alikon - change - 15 Mar 2016
Status New Pending
avatar wilsonge wilsonge - change - 15 Mar 2016
Labels Added: ? ?
avatar MATsxm MATsxm - test_item - 15 Mar 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 15 Mar 2016

I have tested this item :white_check_mark: successfully on e81464e

Able to reproduce then #9439 works as expected - Thanks

Note that everything is ok with #9405


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9439.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 15 Mar 2016 - Tested unsuccessfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 15 Mar 2016

I have tested this item :red_circle: unsuccessfully on e81464e

Got same "Error! Please read the Terms of Service. You will not be able to register if you do not agree with them."


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9439.

avatar alikon
alikon - comment - 15 Mar 2016

@franz-wohlkoenig under what conditions ?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 15 Mar 2016

PHP 5.6.13
MySQLi 5.5.47-0+deb7u1
3.5.0-rc3

Saving an User in Backend bring Error. I reinstalled Patchtester, also Patch, Logout and -in - same Error.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9439.

avatar alikon
alikon - comment - 15 Mar 2016

unable to reproduce under this configurationn of profile plugin on backend

what i'm missing ?
profilep

avatar MATsxm
MATsxm - comment - 15 Mar 2016

for #9439 and with a backend registration with the "User - Profile" plugin unabled

A - before the patch:
1 - if TOS required:
"Error! Please read the Terms of Service. You will not be able to register if you do not agree with them."
2 - if TOS NOT required:
"Error! Please read the Terms of Service. You will not be able to register if you do not agree with them."

B - after the patch:
1 - if TOS required:
"Error! Please read the Terms of Service. You will not be able to register if you do not agree with them."
2 - if TOS NOT required:
"SUCCESS"

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 15 Mar 2016

confirm @MATsxm: if TOS Disabled, no Error. Error if TOS Enabled.

avatar MATsxm MATsxm - test_item - 15 Mar 2016 - Tested unsuccessfully
avatar MATsxm
MATsxm - comment - 15 Mar 2016

I have tested this item :red_circle: unsuccessfully on e81464e

revert to unsuccessfull as if TOS is required, there's still an error for a backend registration - Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9439.

avatar joomla-cms-bot
joomla-cms-bot - comment - 15 Mar 2016

This PR has received new commits.

CC: @franz-wohlkoenig, @MATsxm


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9439.

avatar joomla-cms-bot
joomla-cms-bot - comment - 15 Mar 2016

This PR has received new commits.

CC: @franz-wohlkoenig, @MATsxm


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9439.

avatar alikon
alikon - comment - 15 Mar 2016

added the not in backend condtion

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 15 Mar 2016

Get "Could not connect to GitHub: Bad credentials" at "Fetch Data", so cannot test until i know whats going wrong.

avatar MATsxm MATsxm - test_item - 15 Mar 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 15 Mar 2016

I have tested this item :white_check_mark: successfully on 4e9c941

for a registration on backend with the plg_ "User - Profile" unabled

A - before the patch:
1 - if TOS required:
"Error! Please read the Terms of Service. You will not be able to register if you do not agree with them."
2 - if TOS NOT required:
"Error! Please read the Terms of Service. You will not be able to register if you do not agree with them."

B - after the patch:
1 - if TOS required:
SUCCES
2 - if TOS NOT required:
SUCCESS

Successful test
Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9439.

avatar alikon
alikon - comment - 15 Mar 2016

...sorry guys for extra work ..
i hope there are not more uncovered conditions :stuck_out_tongue_winking_eye:

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 15 Mar 2016 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 15 Mar 2016

I have tested this item :white_check_mark: successfully on 4e9c941


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9439.

avatar wilsonge wilsonge - change - 15 Mar 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-03-15 20:25:16
Closed_By wilsonge
avatar wilsonge wilsonge - close - 15 Mar 2016
avatar wilsonge wilsonge - merge - 15 Mar 2016
avatar wilsonge wilsonge - close - 15 Mar 2016
avatar wilsonge wilsonge - change - 15 Mar 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment