? Pending

User tests: Successful: Unsuccessful:

avatar photodude
photodude
14 Mar 2016

Pull Request for Issues related to #9427 . (note, may not be full coverage of all the issues identified in #9427)

Summary of Changes

Admin "helpers" folder is missing from the com_tags install manifest
"helpers" Folder was being deleted, remove the delete from administrator/components/com_admin/script.php

This completes the necessary Reverts from the 0eb3431 changes

Testing Instructions

from 3.4.8 Install 3.5.RC2
check if the admin administrator/components/com_tags/helpers folder is missing
update the 3.5.RC2 package with this fix
reattempt update from 3.4.8 to the modified 3.5.RC2
administrator/components/com_tags/helpers folder and files should now exist

avatar photodude photodude - open - 14 Mar 2016
avatar photodude photodude - change - 14 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2016
Labels Added: ?
avatar wilsonge
wilsonge - comment - 15 Mar 2016

See @mbabker 's comments in the original issue - it needs more than this!

avatar wilsonge wilsonge - change - 15 Mar 2016
Labels Added: ?
avatar photodude
photodude - comment - 15 Mar 2016

@mbabker should the view.html.php change also be reverted?

avatar wilsonge
wilsonge - comment - 15 Mar 2016

Don't think it's needed is it? It references tags from tags :P

avatar photodude photodude - change - 15 Mar 2016
Title
Admin "helpers" folder is missing from the manifest
Admin "helpers" folder is missing from the Tags manifest - reverts 0eb3431
avatar photodude
photodude - comment - 15 Mar 2016

Thanks @wilsonge, This should be good to go now.

avatar brianteeman
brianteeman - comment - 15 Mar 2016

Can this be closed @wilsonge


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9428.

avatar wilsonge
wilsonge - comment - 15 Mar 2016

I think it needs to be tested + merged

avatar anibalsanchez anibalsanchez - test_item - 15 Mar 2016 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 15 Mar 2016

I have tested this item :white_check_mark: successfully on c01d04e

Test OK. A patched installer works fine and it has the right tags manifest.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9428.

avatar wilsonge wilsonge - reference | 9df009f - 15 Mar 16
avatar wilsonge wilsonge - change - 15 Mar 2016
Milestone Added:
avatar wilsonge wilsonge - change - 15 Mar 2016
Labels Removed: ?
avatar wilsonge
wilsonge - comment - 15 Mar 2016

Merged with 9df009f

avatar wilsonge wilsonge - change - 15 Mar 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-03-15 13:12:07
Closed_By wilsonge
avatar wilsonge wilsonge - close - 15 Mar 2016
avatar wilsonge wilsonge - close - 15 Mar 2016
avatar photodude
photodude - comment - 15 Mar 2016

Thanks @wilsonge

avatar photodude photodude - head_ref_deleted - 15 Mar 2016

Add a Comment

Login with GitHub to post a comment