? ? Success

User tests: Successful: Unsuccessful:

avatar Twincarb
Twincarb
14 Mar 2016

Pull Request for Issue # .

Summary of Changes

Updated en-GB install language

Testing Instructions

code review
The first sentence is left as a cliff hanger, "one" completes the sentence.

If the second sentence is still true the randomly generated prefix would be 3 or 4 alpha numerics, to reflect default being 5 I have adjusted the wording to "for or five" characters long, the last part of the sentence is adjusted for better grammer.

avatar Twincarb Twincarb - open - 14 Mar 2016
avatar Twincarb Twincarb - change - 14 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2016
Labels Added: ? ?
avatar infograf768
infograf768 - comment - 14 Mar 2016

While you are there, please change b to strong.

avatar Twincarb
Twincarb - comment - 14 Mar 2016

@infograf768 with the extra markup, I am now wondering if the only points that need to be emphasised are as below... the first sentence is already given pre filled with the option to change. Whereas the second sentence is an instruction if the default isn't used.

Choose a table prefix or use the randomly generated one, ideally four or five characters long. It may only contain alphanumeric characters and MUST end in an underscore. Make sure that the prefix chosen is not used by other tables.

Choose a table prefix or use the randomly generated one, ideally four or five characters long. It may only contain alphanumeric characters and MUST end in an underscore. Make sure that the prefix chosen is not used by other tables.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9424.

avatar brianteeman brianteeman - change - 14 Mar 2016
Milestone Added:
Labels
Easy No Yes
avatar brianteeman brianteeman - change - 14 Mar 2016
Milestone Added:
avatar brianteeman brianteeman - change - 14 Mar 2016
Category Language & Strings
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Removed:
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Added:
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Added:
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Removed:
avatar andrepereiradasilva
andrepereiradasilva - comment - 23 Mar 2016

IMHO the strong should only be used if is really really important to call for the end user attention.
Also i think you either uses CAPITALIZATION or you use strong, using CAPITALIZATION WITH STRONG, in my personal view, is an overkill and not user friendly.

I think bold in the "must" is enough to call the user attention and still be easily read.

BTW why the "may" and the "MUST" ... aren't both "MUST"?

My proposal:

Create a table prefix or use the randomly generated one. Ideally four or five characters long, it must contain only alphanumeric characters and end in an underscore. Also, make sure that the prefix chosen is not already used by other tables.

avatar Twincarb
Twincarb - comment - 23 Mar 2016

Out of the 3 sentences the 2nd and 3rd are the ones that carry an instruction, I am happy to put the PR forward in all lower case and no emphasis, as I suspect the only time it is read is when someone is installing for the first time, and then they are more likely to read each word and stay with the randomly generated one.

@andrepereiradasilva
The reason for a may and a must come from my work and using legally binding documentation where instructions are formatted in a particular way.
With the "Must" it is an instruction which has something which has to be followed ie it must end in an underscore.
However "May only" gives a degree of optionality, as in we are not instructing that it must contain both letters and numbers, rather it "may only" contain letters or numbers. it's just semantics for a project like Joomla mind.

Am open to any option mind, as minor as it is the wording could be improved.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9424.

avatar brianteeman
brianteeman - comment - 23 Mar 2016

May and must seem correct to me ( as the only non-lawyer in my family :) l

avatar andrepereiradasilva
andrepereiradasilva - comment - 23 Mar 2016

Out of the 3 sentences the 2nd and 3rd are the ones that carry an instruction, I am happy to put the PR forward in all lower case and no emphasis, as I suspect the only time it is read is when someone is installing for the first time, and then they are more likely to read each word and stay with the randomly generated one.

ok.

The reason for a may and a must come from my work and using legally binding documentation where instructions are formatted in a particular way.
With the "Must" it is an instruction which has something which has to be followed ie it must end in an underscore.
However "May only" gives a degree of optionality, as in we are not instructing that it must contain both letters and numbers, rather it "may only" contain letters or numbers. it's just semantics for a project like Joomla mind.

May and must seem correct to me ( as the only non-lawyer in my family :) l

2 to 1, let's democracy play. You win :)

avatar brianteeman brianteeman - test_item - 1 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 1 Apr 2016

I have tested this item :white_check_mark: successfully on 07446df


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9424.

avatar waader waader - test_item - 1 Apr 2016 - Tested successfully
avatar waader
waader - comment - 1 Apr 2016

I have tested this item :white_check_mark: successfully on 07446df


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9424.

avatar brianteeman brianteeman - change - 1 Apr 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 1 Apr 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9424.

avatar joomla-cms-bot joomla-cms-bot - change - 1 Apr 2016
Labels Added: ?
avatar rdeutz rdeutz - reference | 18ce7ed - 12 Apr 16
avatar rdeutz rdeutz - merge - 12 Apr 2016
avatar rdeutz rdeutz - change - 12 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-12 19:43:44
Closed_By rdeutz
avatar rdeutz rdeutz - close - 12 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar brianteeman brianteeman - change - 11 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment