? Success
Pull Request for # 9420

User tests: Successful: Unsuccessful:

avatar alikon
alikon
14 Mar 2016

Pull Request for Issue #9420 .

New category count feature performance degrade

Summary of Changes

Sliptted count queries

Testing Instructions

see #9420 .

avatar alikon alikon - open - 14 Mar 2016
avatar alikon alikon - change - 14 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2016
Labels Added: ?
avatar brianteeman
brianteeman - comment - 14 Mar 2016

confused - what is this pr supposed to do? Remove the category count feature

avatar brianteeman
brianteeman - comment - 14 Mar 2016

ignore me - i guess I tested too quickly - you are still working- sorry

avatar brianteeman brianteeman - change - 14 Mar 2016
Category SQL
avatar brianteeman brianteeman - change - 14 Mar 2016
Rel_Number 0 9420
Relation Type Pull Request for
avatar alikon
alikon - comment - 14 Mar 2016

sorry brian the connection goes down suddenly ....
can you test now

avatar brianteeman brianteeman - test_item - 14 Mar 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 14 Mar 2016

I have tested this item :white_check_mark: successfully on 7c8dafe

With my data from #9420

before

Database queries total: 31358.46 ms

after

Database queries total: 276.19 ms

WOW!!!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9421.

avatar alikon
alikon - comment - 14 Mar 2016

i'm sure we can do even better ;)

avatar Wertos
Wertos - comment - 14 Mar 2016

Before

Total SQL-queries: 21420.74 ms

After

Total SQL-queries: 14.74 ms

Database: 1.4Gb
Materials: >82000
Categories: 46

avatar brianteeman brianteeman - alter_testresult - 14 Mar 2016 - wertos: Tested successfully
avatar brianteeman
brianteeman - comment - 14 Mar 2016

@alikon can you look at the codestyle issues in Travis please and then this can be merged


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9421.

avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Mar 2016

This PR has received new commits.

CC: @brianteeman, @wertos


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9421.

avatar brianteeman brianteeman - change - 14 Mar 2016
The description was changed
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 14 Mar 2016

RTC now that travis is happy - awesome stuff


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9421.

avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2016
Labels Added: ?
avatar wilsonge
wilsonge - comment - 14 Mar 2016

We need to do the same thing to all the other category helpers (e.g. banners https://github.com/alikon/joomla-cms/blob/patch-61/administrator/components/com_banners/helpers/banners.php#L197, newsfeeds etc.)

avatar infograf768
infograf768 - comment - 14 Mar 2016
  • let's not forget hathor.
avatar wilsonge
wilsonge - comment - 14 Mar 2016

We honestly should be doing this in view.html.php - so these variables are not set in the default.php then no Hathor changes required

avatar roland-d
roland-d - comment - 14 Mar 2016

@wilsonge Would be ideal in the view.html.php but then you can't override it anymore. Perhaps in a JLayout?

avatar wilsonge
wilsonge - comment - 14 Mar 2016

Why should you be able to override a database query?

avatar roland-d
roland-d - comment - 14 Mar 2016

@wilsonge because that is what is causing the performance degredation or does the sql change already account for that?

avatar wilsonge
wilsonge - comment - 14 Mar 2016
avatar roland-d
roland-d - comment - 14 Mar 2016

In that case the code can remain in the model or not?

avatar wilsonge
wilsonge - comment - 14 Mar 2016

It could go in getItems in the model I think yes - not the getQuery where it currently resides tho

avatar roland-d
roland-d - comment - 14 Mar 2016

It is in the getListQuery() but yes, perhaps getItems() is better.

avatar wilsonge
wilsonge - comment - 14 Mar 2016

I have written a PR that uses this but moves the code out of the com_content view and also does it across all the extensions with this feature. Closing in favour of #9429

avatar wilsonge wilsonge - change - 14 Mar 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-03-14 23:42:18
Closed_By wilsonge
avatar wilsonge wilsonge - close - 14 Mar 2016
avatar joomla-cms-bot joomla-cms-bot - close - 14 Mar 2016
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment