User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
ignore me - i guess I tested too quickly - you are still working- sorry
Category | ⇒ | SQL |
Rel_Number | 0 | ⇒ | 9420 |
Relation Type | ⇒ | Pull Request for |
sorry brian the connection goes down suddenly ....
can you test now
I have tested this item successfully on 7c8dafe
With my data from #9420
Database queries total: 31358.46 ms
Database queries total: 276.19 ms
WOW!!!
i'm sure we can do even better ;)
Total SQL-queries: 21420.74 ms
Total SQL-queries: 14.74 ms
Database: 1.4Gb
Materials: >82000
Categories: 46
@alikon can you look at the codestyle issues in Travis please and then this can be merged
This PR has received new commits.
CC: @brianteeman, @wertos
Status | Pending | ⇒ | Ready to Commit |
RTC now that travis is happy - awesome stuff
Labels |
Added:
?
|
We need to do the same thing to all the other category helpers (e.g. banners https://github.com/alikon/joomla-cms/blob/patch-61/administrator/components/com_banners/helpers/banners.php#L197, newsfeeds etc.)
We honestly should be doing this in view.html.php - so these variables are not set in the default.php then no Hathor changes required
Why should you be able to override a database query?
In that case the code can remain in the model or not?
It could go in getItems in the model I think yes - not the getQuery where it currently resides tho
It is in the getListQuery() but yes, perhaps getItems() is better.
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-14 23:42:18 |
Closed_By | ⇒ | wilsonge |
Labels |
Removed:
?
|
confused - what is this pr supposed to do? Remove the category count feature