? ? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
14 Mar 2016

Summary of Changes

In step 2, field "Old Database Process" of installation process there is a text that says:

image

But this is not entirely true in some cases: we can have a "former Joomla! installation" with a different table prefix and the installer will not do nothing to those tables.

In this scenario, the installer will not backup them (it makes no sense as they will not be overwritten), and it will not remove them either (as those tables can be from a different Joomla install in the same database).

So the behavior itself is correct, but IMHO the description text can be improved.

In this PR i propose to change this text to:

"Backup" or "Remove" any existing tables from former Joomla! installations with the same "Table Prefix".

Testing Instructions

Check code changes.

Observations

Since this does nothing to the database (the process is for the tables), maybe "Old database process" is not also the best text for the field...

avatar andrepereiradasilva andrepereiradasilva - open - 14 Mar 2016
avatar andrepereiradasilva andrepereiradasilva - change - 14 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2016
Labels Added: ? ?
avatar brianteeman brianteeman - change - 14 Mar 2016
Milestone Added:
Labels
avatar brianteeman brianteeman - change - 14 Mar 2016
Milestone Added:
avatar brianteeman brianteeman - change - 14 Mar 2016
Category Installation Language & Strings
avatar andrepereiradasilva andrepereiradasilva - change - 14 Mar 2016
Easy No Yes
avatar MATsxm MATsxm - test_item - 16 Mar 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 16 Mar 2016

I have tested this item :white_check_mark: successfully on 660d27b

Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9419.

avatar zero-24 zero-24 - test_item - 16 Mar 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 16 Mar 2016

I have tested this item :white_check_mark: successfully on 660d27b

Ok Simple fix :)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9419.

avatar brianteeman brianteeman - change - 16 Mar 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 16 Mar 2016

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9419.

avatar joomla-cms-bot joomla-cms-bot - change - 16 Mar 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Removed:
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Added:
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Added:
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Removed:
avatar rdeutz rdeutz - reference | 121da2a - 12 Apr 16
avatar rdeutz rdeutz - merge - 12 Apr 2016
avatar rdeutz rdeutz - change - 12 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-12 19:42:07
Closed_By rdeutz
avatar rdeutz rdeutz - close - 12 Apr 2016
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 12 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar brianteeman brianteeman - change - 11 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment